r71198 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71197‎ | r71198 | r71199 >
Date:12:51, 17 August 2010
Author:demon
Status:resolved
Tags:
Comment:
Wow I'm a hypocrite. After constantly telling people that back-compat hacks suck and have no place in trunk, I find one in my own extension. Wtf was I thinking?
Modified paths:
  • /trunk/extensions/StalkerLog/StalkerLog.php (modified) (history)

Diff [purge]

Index: trunk/extensions/StalkerLog/StalkerLog.php
@@ -34,12 +34,6 @@
3535 $wgLogRestrictions['stalkerlog'] = 'stalkerlog-view-log';
3636 $wgLogActions['stalkerlog/login'] = 'stalkerlog-log-login';
3737
38 -# 1.13+ setup only
39 -if ( version_compare( $wgVersion, '1.13', '>=' ) ) {
40 - $wgHooks['UserLogoutComplete'][] = 'wfStalkerLogout';
41 - $wgLogActions['stalkerlog/logout'] = 'stalkerlog-log-logout';
42 -}
43 -
4438 # Login hook function
4539 function wfStalkerLogin( &$user ) {
4640 wfLoadExtensionMessages('stalkerlog');

Follow-up revisions

RevisionCommit summaryAuthorDate
r71199Followup r71198: when you're being snarky, it helps to not break the code too.demon12:52, 17 August 2010

Status & tagging log