r71179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71178‎ | r71179 | r71180 >
Date:00:07, 17 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
Fixed syntax errors
Modified paths:
  • /branches/resourceloader/phase3/resources/mediawiki/legacy/mediawiki.legacy.ajax.js (modified) (history)
  • /branches/resourceloader/phase3/resources/mediawiki/legacy/mediawiki.legacy.edit.js (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/resources/mediawiki/legacy/mediawiki.legacy.ajax.js
@@ -9,7 +9,6 @@
1010 ( function( $, mw ) {
1111
1212 /* Extension */
13 -
1413 $.extend( true, mw.legacy, {
1514
1615 /* Global Variables */
Index: branches/resourceloader/phase3/resources/mediawiki/legacy/mediawiki.legacy.edit.js
@@ -39,8 +39,8 @@
4040 'width': 23,
4141 'height': 22,
4242 'class': 'mw-toolbar-editbutton',
43 - 'id': item.imageId ? item.imageId : null,
44 - 'src': = item.imageFile,
 43+ 'id': ( item.imageId ? item.imageId : null ),
 44+ 'src': item.imageFile,
4545 'border': 0,
4646 'alt': item.speedTip,
4747 'title': item.speedTip
@@ -102,13 +102,13 @@
103103 typeof $.fn.textSelection != 'undefined' &&
104104 ( $currentFocused.name().toLowerCase() == 'iframe' || $currentFocused.attr( 'id' ) == 'wpTextbox1' )
105105 ) {
106 - $j( '#wpTextbox1' ).textSelection(
 106+ $( '#wpTextbox1' ).textSelection(
107107 'encapsulateSelection', { 'pre': tagOpen, 'peri': sampleText, 'post': tagClose }
108108 );
109109 return;
110110 }
111111 var $textarea;
112 - if ( $( 'form[name=editform]' ) {
 112+ if ( $( 'form[name=editform]' ) ) {
113113 $textarea = $currentFocused;
114114 } else {
115115 // Some alternate form? take the first one we can find
@@ -220,9 +220,9 @@
221221 } );
222222 // HACK: make currentFocused work with the usability iframe - with proper focus detection support (HTML 5!) this'll
223223 // be much cleaner
224 - var $iframe = $j( '.wikiEditor-ui-text iframe' );
 224+ var $iframe = $( '.wikiEditor-ui-text iframe' );
225225 if ( $iframe.length > 0 ) {
226 - $j( $iframe.get( 0 ).contentWindow.document )
 226+ $( $iframe.get( 0 ).contentWindow.document )
227227 // For IE
228228 .add( $iframe.get( 0 ).contentWindow.document.body )
229229 .focus( function() { mw.legacy.currentFocused = $iframe.get( 0 ); } );

Status & tagging log