r71178 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71177‎ | r71178 | r71179 >
Date:23:58, 16 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
Added cast to array to $files argument in ResourceLoaderModule::concatFiles before we pass it to array_unique
Modified paths:
  • /branches/resourceloader/phase3/includes/ResourceLoaderModule.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/ResourceLoaderModule.php
@@ -307,7 +307,7 @@
308308 * @return string Concatenated contents of $files
309309 */
310310 protected static function concatFiles( $files ) {
311 - return implode( "\n", array_map( 'file_get_contents', array_unique( $files ) ) );
 311+ return implode( "\n", array_map( 'file_get_contents', array_unique( (array) $files ) ) );
312312 }
313313
314314 }

Status & tagging log