r71118 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71117‎ | r71118 | r71119 >
Date:14:49, 15 August 2010
Author:maxsem
Status:resolved (Comments)
Tags:
Comment:
Fixed SQLite updater broken by r69542
Modified paths:
  • /trunk/phase3/maintenance/sqlite/archives/patch-iw_api_and_wikiid.sql (added) (history)

Diff [purge]

Index: trunk/phase3/maintenance/sqlite/archives/patch-iw_api_and_wikiid.sql
@@ -0,0 +1,17 @@
 2+--
 3+-- Add iw_api and iw_wikiid to interwiki table
 4+--
 5+
 6+
 7+CREATE TABLE /*_*/interwiki_tmp (
 8+ iw_prefix TEXT NOT NULL,
 9+ iw_url BLOB NOT NULL,
 10+ iw_api BLOB NOT NULL,
 11+ iw_wikiid TEXT NOT NULL,
 12+ iw_local INTEGER NOT NULL,
 13+ iw_trans INTEGER NOT NULL default 0
 14+) /*$wgDBTableOptions*/;
 15+
 16+INSERT INTO /*_*/interwiki_tmp SELECT iw_prefix, iw_url, '', '', iw_local, iw_trans FROM /*_*/interwiki;
 17+DROP TABLE /*_*/interwiki;
 18+ALTER TABLE /*_*/interwiki_tmp RENAME TO /*_*/interwiki;
Property changes on: trunk/phase3/maintenance/sqlite/archives/patch-iw_api_and_wikiid.sql
___________________________________________________________________
Added: svn:eol-style
119 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r72879Follow-up r71118: forgot to re-add the indexmaxsem18:00, 12 September 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69542Add iw_api and iw_wikiid fields to the interwiki table, plus rudimentary supp...catrope11:55, 19 July 2010

Comments

#Comment by Catrope (talk | contribs)   16:13, 23 August 2010

Will this preserve indexes on the interwiki table?

#Comment by MaxSem (talk | contribs)   16:49, 23 August 2010

My bad, will post a fix shortly. I need to finish my schema verification tool to help myself and others to avoid such things.

#Comment by MaxSem (talk | contribs)   18:12, 23 August 2010

Wait, there's only one index on that table in trunk. Is that expected, or later changes broke something?

#Comment by Catrope (talk | contribs)   18:50, 23 August 2010

That is expected.

Status & tagging log