r71030 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r71029‎ | r71030 | r71031 >
Date:14:38, 13 August 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Partial revert r71029, unrelated changes. Need caffeine before I commit
Modified paths:
  • /trunk/phase3/includes/specials/SpecialVersion.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/maintenance/language/messages.inc (modified) (history)
  • /trunk/phase3/maintenance/tests/UploadFromUrlTestSuite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/tests/UploadFromUrlTestSuite.php
@@ -46,7 +46,7 @@
4747 $parserMemc =& wfGetParserCacheStorage();
4848
4949 //$wgContLang = new StubContLang;
50 - $wgUser = new User;
 50+ $wgUser = new StubUser;
5151 $wgLang = new StubUserLang;
5252 $wgOut = new StubObject( 'wgOut', 'OutputPage' );
5353 $wgParser = new StubObject( 'wgParser', $wgParserConf['class'], array( $wgParserConf ) );
Index: trunk/phase3/maintenance/language/messages.inc
@@ -3137,8 +3137,6 @@
31383138 'version-version',
31393139 'version-svn-revision',
31403140 'version-license',
3141 - 'version-poweredby-credits',
3142 - 'version-license-info',
31433141 'version-software',
31443142 'version-software-product',
31453143 'version-software-version',
Index: trunk/phase3/includes/specials/SpecialVersion.php
@@ -70,22 +70,33 @@
7171 * @return string
7272 */
7373 private static function getMediaWikiCredits() {
74 - global $wgLang;
75 -
76 - $authorList = array( 'Magnus Manske', 'Brion Vibber', 'Lee Daniel Crocker',
77 - 'Tim Starling', 'Erik Möller', 'Gabriel Wicke', 'Ævar Arnfjörð Bjarmason',
78 - 'Niklas Laxström', 'Domas Mituzas', 'Rob Church', 'Yuri Astrakhan',
79 - 'Aryeh Gregor', 'Aaron Schulz', 'Andrew Garrett', 'Raimond Spekking',
80 - 'Alexandre Emsenhuber', 'Siebrand Mazeland', 'Chad Horohoe', 'others'
81 - );
8274 $ret = Xml::element( 'h2', array( 'id' => 'mw-version-license' ), wfMsg( 'version-license' ) );
8375
8476 // This text is always left-to-right.
85 - $ret .= '<div>';
 77+ $ret .= '<div dir="ltr">';
8678 $ret .= "__NOTOC__
87 - " . wfMsg( 'version-poweredby-credits', date( 'Y' ),
88 - $wgLang->listToText( $authorList ) ) . "\n
89 - " . wfMsg( 'version-license-info' );
 79+ This wiki is powered by '''[http://www.mediawiki.org/ MediaWiki]''',
 80+ copyright © 2001-2010 Magnus Manske, Brion Vibber, Lee Daniel Crocker,
 81+ Tim Starling, Erik Möller, Gabriel Wicke, Ævar Arnfjörð Bjarmason,
 82+ Niklas Laxström, Domas Mituzas, Rob Church, Yuri Astrakhan, Aryeh Gregor,
 83+ Aaron Schulz, Andrew Garrett, Raimond Spekking, Alexandre Emsenhuber,
 84+ Siebrand Mazeland, Chad Horohoe and others.
 85+
 86+ MediaWiki is free software; you can redistribute it and/or modify
 87+ it under the terms of the GNU General Public License as published by
 88+ the Free Software Foundation; either version 2 of the License, or
 89+ (at your option) any later version.
 90+
 91+ MediaWiki is distributed in the hope that it will be useful,
 92+ but WITHOUT ANY WARRANTY; without even the implied warranty of
 93+ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 94+ GNU General Public License for more details.
 95+
 96+ You should have received [{{SERVER}}{{SCRIPTPATH}}/COPYING a copy of the GNU General Public License]
 97+ along with this program; if not, write to the Free Software
 98+ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
 99+ or [http://www.gnu.org/licenses/old-licenses/gpl-2.0.html read it online].
 100+ ";
90101 $ret .= '</div>';
91102
92103 return str_replace( "\t\t", '', $ret ) . "\n";
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -4242,22 +4242,6 @@
42434243 'version-version' => '(Version $1)',
42444244 'version-svn-revision' => '(r$2)', # only translate this message to other languages if you have to change it
42454245 'version-license' => 'License',
4246 -'version-poweredby-credits' => "This wiki is powered by '''[http://www.mediawiki.org/ MediaWiki]''', copyright © 2001-$1 $2.", // $1 is the current year, $2 is the list of authors
4247 -'version-license-info' => "MediaWiki is free software; you can redistribute it and/or modify
4248 - it under the terms of the GNU General Public License as published by
4249 - the Free Software Foundation; either version 2 of the License, or
4250 - (at your option) any later version.
4251 -
4252 - MediaWiki is distributed in the hope that it will be useful,
4253 - but WITHOUT ANY WARRANTY; without even the implied warranty of
4254 - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4255 - GNU General Public License for more details.
4256 -
4257 - You should have received [{{SERVER}}{{SCRIPTPATH}}/COPYING a copy of the GNU General Public License]
4258 - along with this program; if not, write to the Free Software
4259 - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
4260 - or [http://www.gnu.org/licenses/old-licenses/gpl-2.0.html read it online].
4261 - ",
42624246 'version-software' => 'Installed software',
42634247 'version-software-product' => 'Product',
42644248 'version-software-version' => 'Version',

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r71029Fix #1 for r70970: Make UploadFromUrlTestSuite initialize a User instead of S...demon14:36, 13 August 2010

Comments

#Comment by 😂 (talk | contribs)   14:39, 13 August 2010

And by partial I really mean full.

I'm walking away until I get some breakfast. I'm obviously not thinking clearly at all.

Status & tagging log