r70907 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70906‎ | r70907 | r70908 >
Date:18:53, 11 August 2010
Author:kaldari
Status:ok (Comments)
Tags:
Comment:
moving patch-add-preferred.sql prior to adding to update hook
Modified paths:
  • /trunk/extensions/CentralNotice/patches/patch-add-preferred.sql (deleted) (history)
  • /trunk/extensions/CentralNotice/patches/patch-notice_languages.sql (modified) (history)
  • /trunk/extensions/CentralNotice/patches/patch-notice_preferred.sql (added) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/patches/patch-add-preferred.sql
@@ -1,6 +0,0 @@
2 -# Support for one notice to supercede all others. This allows one notice to
3 -# cancel out all the templates that a non preffered notice might have if they
4 -# overlap. Use case is to be able to use one all language and projects notice
5 -# and have it superceded by a specific one for en wikipedia.
6 -
7 -ALTER TABLE cn_notices ADD COLUMN not_preferred bool NOT NULL default '0';
Index: trunk/extensions/CentralNotice/patches/patch-notice_languages.sql
@@ -1,9 +1,8 @@
22 -- Update to allow for any number of languages per notice.
33
44 CREATE TABLE IF NOT EXISTS /*$wgDBprefix*/cn_notice_languages (
5 - `id` int unsigned NOT NULL auto_increment,
 5+ `id` int unsigned NOT NULL auto_increment PRIMARY KEY,
66 `not_id` int unsigned NOT NULL,
7 - `not_language` varchar(32) NOT NULL,
8 - PRIMARY KEY (`id`),
9 - UNIQUE KEY `not_id_not_language` (`not_id`,`not_language`)
10 -) /*$wgDBTableOptions*/;
\ No newline at end of file
 7+ `not_language` varchar(32) NOT NULL
 8+) /*$wgDBTableOptions*/;
 9+CREATE INDEX /*i*/cn_not_id_not_language ON /*$wgDBprefix*/cn_notice_languages (not_id, not_language);
\ No newline at end of file
Index: trunk/extensions/CentralNotice/patches/patch-notice_preferred.sql
@@ -0,0 +1,6 @@
 2+# Support for one notice to supercede all others. This allows one notice to
 3+# cancel out all the templates that a non preffered notice might have if they
 4+# overlap. Use case is to be able to use one all language and projects notice
 5+# and have it superceded by a specific one for en wikipedia.
 6+
 7+ALTER TABLE cn_notices ADD COLUMN not_preferred bool NOT NULL default '0';
Property changes on: trunk/extensions/CentralNotice/patches/patch-notice_preferred.sql
___________________________________________________________________
Added: svn:eol-style
18 + native

Follow-up revisions

RevisionCommit summaryAuthorDate
r71220fixing SQL error introduced in r70969, making index from r70907 UNIQUEkaldari23:38, 17 August 2010

Comments

#Comment by Kaldari (talk | contribs)   19:03, 11 August 2010

added newline at EOF for patch-notice_languages.sql in r70912

Status & tagging log