r70904 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70903‎ | r70904 | r70905 >
Date:18:36, 11 August 2010
Author:kaldari
Status:resolved (Comments)
Tags:
Comment:
localizing comma list per comment at r68694
Modified paths:
  • /trunk/extensions/CentralNotice/SpecialCentralNotice.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CentralNotice/SpecialCentralNotice.php
——@@ -478,7 +478,7 @@
479479 if ( $language_count > 3 ) {
480480 $languageList = wfMsg ( 'centralnotice-multiple_languages', $language_count );
481481 } elseif ( $language_count > 0 ) {
482 - $languageList = implode(', ',$project_langs);
 482+ $languageList = Language::commaList( $project_langs );
483483 }
484484 $fields[] = $languageList;
485485

Follow-up revisions

RevisionCommit summaryAuthorDate
r70905CentralNotice: fixes for r70904: Language::commaList() is not static, fixed g...maxsem18:45, 11 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68694handle small numbers of languages better in interface displaykaldari01:21, 29 June 2010

Comments

#Comment by Catrope (talk | contribs)   12:20, 12 August 2010 
+					$languageList = Language::commaList( $project_langs );

I meant $wgLang->commaList(), it's not a static method. I'm sorry if I was unclear about this before.

#Comment by Catrope (talk | contribs)   12:21, 12 August 2010

Oops, was fixed already in r70905.

Status & tagging log