r70803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70802‎ | r70803 | r70804 >
Date:09:30, 10 August 2010
Author:peter17
Status:ok
Tags:
Comment:
Fix remarks about r70802
Modified paths:
  • /branches/iwtransclusion/phase3/includes/Article.php (modified) (history)
  • /branches/iwtransclusion/phase3/includes/BacklinkCache.php (modified) (history)

Diff [purge]

Index: branches/iwtransclusion/phase3/includes/Article.php
@@ -4161,7 +4161,6 @@
41624162
41634163 // Invalidate caches of distant articles which transclude this page
41644164 $wgDeferredUpdateList[] = new HTMLCacheUpdate( $title, 'globaltemplatelinks' );
4165 - wfDoUpdates();
41664165
41674166 // Invalidate the caches of all pages which redirect here
41684167 $wgDeferredUpdateList[] = new HTMLCacheUpdate( $title, 'redirect' );
Index: branches/iwtransclusion/phase3/includes/BacklinkCache.php
@@ -109,10 +109,7 @@
110110
111111 /**
112112 * Get the distant backtemplatelinks for the table globaltemplatelinks. Cached in process memory only.
113 - * @param $table String
114 - * @param $startId Integer or false
115 - * @param $endId Integer or false
116 - * @return TitleArray
 113+ * @return ResultWrapper list of distant pages that use the local title
117114 */
118115 public function getDistantTemplateLinks( ) {
119116 global $wgGlobalDatabase, $wgLocalInterwiki;
@@ -122,8 +119,7 @@
123120 array( 'globaltemplatelinks' ),
124121 array( 'gtl_from_wiki', 'gtl_from_page' ),
125122 array( 'gtl_to_prefix' => $wgLocalInterwiki, 'gtl_to_title' => $this->title->getDBkey( ) ),
126 - __METHOD__,
127 - 'GROUP BY gtl_from_wiki'
 123+ __METHOD__
128124 );
129125 return $res;
130126 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r87110Merge r70803, r70951reedy00:48, 29 April 2011
r92995Merge r87110, Merge of r70803, r70951reedy18:22, 24 July 2011

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70802Fix remarks about r70764; invalidate the cache of the distant pages when the ...peter1709:11, 10 August 2010

Status & tagging log