r70779 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70778‎ | r70779 | r70780 >
Date:20:36, 9 August 2010
Author:raymond
Status:ok (Comments)
Tags:
Comment:
* (bug 21052) Fix link color for stubs in NewPages
Modified paths:
  • /trunk/phase3/RELEASE-NOTES (modified) (history)
  • /trunk/phase3/includes/specials/SpecialNewpages.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialNewpages.php
——@@ -280,7 +280,8 @@
281281 $title,
282282 null,
283283 array( 'class' => 'mw-newpages-pagename' ),
284 - $query
 284+ $query,
 285+ array( 'known' ) // Set explicitly to avoid the default of 'known','noclasses'. This breaks the colouration for stubs
285286 );
286287 $histLink = $this->skin->linkKnown(
287288 $title,
Index: trunk/phase3/RELEASE-NOTES
——@@ -286,6 +286,7 @@
287287 to avoid query errors about duplicate keynames.
288288 * (bug 15470) First letters of filenames are always capitalized by upload JS.
289289 * (bug 21215) NoLocalSettings.php doesn't tolerate rewrite rules
 290+* (bug 21052) Fix link color for stubs in NewPages
290291
291292 === API changes in 1.17 ===
292293 * (bug 22738) Allow filtering by action type on query=logevent.

Comments

#Comment by Platonides (talk | contribs)   20:53, 9 August 2010

I think the proper fix would be to remove the noclasses from linkKnown(), since that's used by many Special pages that will also be affected by this.

But changing the Skins first to avoid the issues r55983 tried to fix.

Status & tagging log