r70770 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70769‎ | r70770 | r70771 >
Date:16:26, 9 August 2010
Author:soxred93
Status:resolved (Comments)
Tags:
Comment:
Followup to r70701: Facepalm fixing.
Modified paths:
  • /trunk/phase3/includes/api/ApiQueryPageProps.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryPageProps.php
@@ -72,7 +72,7 @@
7373
7474
7575 foreach ( $this->everything as $pageid => $title ) {
76 - $pageInfo = $this->extractPageInfo( $pageid, $title, $prop );
 76+ $pageInfo = $this->extractPageInfo( $pageid, $title, $params['prop'] );
7777 $fit = $result->addValue( array(
7878 'query',
7979 'pages'
@@ -121,7 +121,7 @@
122122 return $pageInfo;
123123 }
124124
125 - public function getCacheMode() {
 125+ public function getCacheMode( $params ) {
126126 return 'public';
127127 }
128128

Follow-up revisions

RevisionCommit summaryAuthorDate
r70782Fix r70770: Will I ever get this working? :)soxred9321:03, 9 August 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70701Followup to r70638: Clean up code, add prop to function args, add commentsoxred9314:55, 8 August 2010

Comments

#Comment by Catrope (talk | contribs)   17:19, 9 August 2010

$params isn't set either, it was set as $this->params instead.

#Comment by X! (talk | contribs)   21:03, 9 August 2010

Fixed.

Status & tagging log