r70767 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70766‎ | r70767 | r70768 >
Date:15:28, 9 August 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
It should only be saved in the ParserCache if it IS cacheable.
Confusion in r67185, when translating the original condition (!= -1)
into the new isCacheable().
Modified paths:
  • /trunk/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/OutputPage.php
——@@ -1061,7 +1061,7 @@
10621062 $popts, true, true, $this->mRevisionId
10631063 );
10641064 $popts->setTidy( false );
1065 - if ( $cache && $article && !$parserOutput->isCacheable() ) {
 1065+ if ( $cache && $article && $parserOutput->isCacheable() ) {
10661066 $parserCache = ParserCache::singleton();
10671067 $parserCache->save( $parserOutput, $article, $popts );
10681068 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r67185allow parser/extensions to control for how long a ParserOutput gets cached. I...daniel14:28, 1 June 2010

Comments

#Comment by Duesentrieb (talk | contribs)   18:45, 9 August 2010

oops, thanks for catching that.

#Comment by Platonides (talk | contribs)   19:53, 9 August 2010

No problem :)

Status & tagging log