r70732 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70731‎ | r70732 | r70733 >
Date:01:29, 9 August 2010
Author:soxred93
Status:deferred (Comments)
Tags:
Comment:
Followup to r70638: Add $wgPageProps functionality to all extensions that add their own properties.
Modified paths:
  • /trunk/extensions/ApprovedRevs/ApprovedRevs.php (modified) (history)
  • /trunk/extensions/MultilingualLiquidThreads/MultilangLqt.php (modified) (history)
  • /trunk/extensions/SemanticDrilldown/includes/SD_Settings.php (modified) (history)
  • /trunk/extensions/SemanticForms/includes/SF_Settings.php (modified) (history)
  • /trunk/extensions/TemplateInfo/TemplateInfo.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MultilingualLiquidThreads/MultilangLqt.php
@@ -34,3 +34,6 @@
3535 $wgHooks['LiquidThreadsEndOfShowNewThreadForm'][] = 'MultilangLqtHooks::showLanguageSelector';
3636 $wgHooks['LiquidThreadsShowReplyForm'][] = 'MultilangLqtHooks::showLanguageSelector';
3737
 38+$wgPageProps['use-liquid-threads'] = 'Whether or not the page uses LiquidThreads';
 39+
 40+
Index: trunk/extensions/SemanticForms/includes/SF_Settings.php
@@ -99,3 +99,8 @@
100100 # speed
101101 # ##
102102 $sfgCacheFormDefinitions = false;
 103+
 104+# ##
 105+# Page properties, used for the API
 106+# ##
 107+$wgPageProps['formdefinition'] = 'Definition of the semantic form used on the page';
Index: trunk/extensions/TemplateInfo/TemplateInfo.php
@@ -48,3 +48,6 @@
4949
5050 // Register API action
5151 $wgAPIPropModules['templateinfo'] = 'ApiQueryTemplateInfo';
 52+
 53+// Register page_props usage
 54+$wgPageProps['templateinfo'] = 'Content of <templateinfo> tag';
Index: trunk/extensions/ApprovedRevs/ApprovedRevs.php
@@ -65,3 +65,5 @@
6666 $wgGroupPermissions['sysop']['approverevisions'] = true;
6767 $wgAvailableRights[] = 'viewlinktolatest';
6868 $wgGroupPermissions['*']['viewlinktolatest'] = true;
 69+
 70+$wgPageProps['approvedrevs'] = 'Whether or not the page is approvable';
Index: trunk/extensions/SemanticDrilldown/includes/SD_Settings.php
@@ -55,4 +55,7 @@
5656 $sdgFiltersSmallestFontSize = - 1;
5757 $sdgFiltersLargestFontSize = - 1;
5858 // print categories list as tabs
59 -$sdgShowCategoriesAsTabs = false;
\ No newline at end of file
 59+$sdgShowCategoriesAsTabs = false;
 60+
 61+$wgPageProps['hidefromdrilldown'] = 'Whether or not the page is set as HIDEFROMDRILLDOWN';
 62+$wgPageProps['showindrilldown'] = 'Whether or not the page is set as SHOWINDRILLDOWN';
\ No newline at end of file

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70638-(bug 24484) Add prop=pageprops module...soxred9318:50, 7 August 2010

Comments

#Comment by Siebrand (talk | contribs)   07:02, 9 August 2010

Is this text shown in the interface anywhere? If so, this is an i18n FIXME and a key should be set instead of hard coded text.

#Comment by X! (talk | contribs)   15:52, 9 August 2010

The text is shown in the API help page.

#Comment by Siebrand (talk | contribs)   16:53, 9 August 2010

OK. I think that API should be in the global, then ($wgApiPageProps?).

#Comment by Bryan (talk | contribs)   19:13, 10 September 2010

I agree with Siebrand. Setting fixme.

#Comment by X! (talk | contribs)   19:16, 10 September 2010

None of the other API text is localizable, AFAIK.

#Comment by Bryan (talk | contribs)   19:52, 10 September 2010

I was referring to the second comment ($wgApiPageProps), but on second thought it doesn't really matter that much.

Status & tagging log