r70702 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70701‎ | r70702 | r70703 >
Date:14:58, 8 August 2010
Author:ialex
Status:ok (Comments)
Tags:
Comment:
Removed PHP4-ism
Modified paths:
  • /trunk/phase3/includes/RawPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/RawPage.php
@@ -23,15 +23,15 @@
2424 var $mSmaxage, $mMaxage;
2525 var $mContentType, $mExpandTemplates;
2626
27 - function __construct( &$article, $request = false ) {
 27+ function __construct( Article $article, $request = false ) {
2828 global $wgRequest, $wgInputEncoding, $wgSquidMaxage, $wgJsMimeType, $wgGroupPermissions;
2929
3030 $allowedCTypes = array('text/x-wiki', $wgJsMimeType, 'text/css', 'application/x-zope-edit');
31 - $this->mArticle =& $article;
32 - $this->mTitle =& $article->mTitle;
 31+ $this->mArticle = $article;
 32+ $this->mTitle = $article->mTitle;
3333
3434 if( $request === false ) {
35 - $this->mRequest =& $wgRequest;
 35+ $this->mRequest = $wgRequest;
3636 } else {
3737 $this->mRequest = $request;
3838 }

Comments

#Comment by Hashar (talk | contribs)   11:43, 25 October 2010

ok -> new I have made a mistake. Introducing type hinting in __contruct() migth break something.

Status & tagging log