r70699 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70698‎ | r70699 | r70700 >
Date:14:23, 8 August 2010
Author:ialex
Status:deferred
Tags:
Comment:
* Standardised file description headers
* Added some descriptions
* Added @file where needed
Modified paths:
  • /trunk/phase3/includes/AjaxFunctions.php (modified) (history)
  • /trunk/phase3/includes/AjaxResponse.php (modified) (history)
  • /trunk/phase3/includes/AutoLoader.php (modified) (history)
  • /trunk/phase3/includes/BagOStuff.php (modified) (history)
  • /trunk/phase3/includes/Credits.php (modified) (history)
  • /trunk/phase3/includes/DjVuImage.php (modified) (history)
  • /trunk/phase3/includes/Exception.php (modified) (history)
  • /trunk/phase3/includes/Exif.php (modified) (history)
  • /trunk/phase3/includes/Hooks.php (modified) (history)
  • /trunk/phase3/includes/IP.php (modified) (history)
  • /trunk/phase3/includes/Import.php (modified) (history)
  • /trunk/phase3/includes/ImportXMLReader.php (modified) (history)
  • /trunk/phase3/includes/MagicWord.php (modified) (history)
  • /trunk/phase3/includes/Metadata.php (modified) (history)
  • /trunk/phase3/includes/MimeMagic.php (modified) (history)
  • /trunk/phase3/includes/ProtectionForm.php (modified) (history)
  • /trunk/phase3/includes/RawPage.php (modified) (history)
  • /trunk/phase3/includes/RecentChange.php (modified) (history)
  • /trunk/phase3/includes/RevisionDelete.php (modified) (history)
  • /trunk/phase3/includes/Sanitizer.php (modified) (history)
  • /trunk/phase3/includes/SkinTemplate.php (modified) (history)
  • /trunk/phase3/includes/WikiError.php (modified) (history)
  • /trunk/phase3/includes/proxy_check.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/ProtectionForm.php
@@ -1,6 +1,8 @@
22 <?php
33 /**
4 - * Copyright (C) 2005 Brion Vibber <brion@pobox.com>
 4+ * Page protection
 5+ *
 6+ * Copyright © 2005 Brion Vibber <brion@pobox.com>
57 * http://www.mediawiki.org/
68 *
79 * This program is free software; you can redistribute it and/or modify
@@ -17,6 +19,8 @@
1820 * with this program; if not, write to the Free Software Foundation, Inc.,
1921 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
2022 * http://www.gnu.org/copyleft/gpl.html
 23+ *
 24+ * @file
2125 */
2226
2327 /**
Index: trunk/phase3/includes/BagOStuff.php
@@ -1,31 +1,34 @@
22 <?php
3 -#
4 -# Copyright (C) 2003-2004 Brion Vibber <brion@pobox.com>
5 -# http://www.mediawiki.org/
6 -#
7 -# This program is free software; you can redistribute it and/or modify
8 -# it under the terms of the GNU General Public License as published by
9 -# the Free Software Foundation; either version 2 of the License, or
10 -# (at your option) any later version.
11 -#
12 -# This program is distributed in the hope that it will be useful,
13 -# but WITHOUT ANY WARRANTY; without even the implied warranty of
14 -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 -# GNU General Public License for more details.
16 -#
17 -# You should have received a copy of the GNU General Public License along
18 -# with this program; if not, write to the Free Software Foundation, Inc.,
19 -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
20 -# http://www.gnu.org/copyleft/gpl.html
21 -
223 /**
23 - * @defgroup Cache Cache
 4+ * Classes to cache objects in PHP accelerators, SQL database or DBA files
245 *
 6+ * Copyright © 2003-2004 Brion Vibber <brion@pobox.com>
 7+ * http://www.mediawiki.org/
 8+ *
 9+ * This program is free software; you can redistribute it and/or modify
 10+ * it under the terms of the GNU General Public License as published by
 11+ * the Free Software Foundation; either version 2 of the License, or
 12+ * (at your option) any later version.
 13+ *
 14+ * This program is distributed in the hope that it will be useful,
 15+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 16+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 17+ * GNU General Public License for more details.
 18+ *
 19+ * You should have received a copy of the GNU General Public License along
 20+ * with this program; if not, write to the Free Software Foundation, Inc.,
 21+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 22+ * http://www.gnu.org/copyleft/gpl.html
 23+ *
2524 * @file
2625 * @ingroup Cache
2726 */
2827
2928 /**
 29+ * @defgroup Cache Cache
 30+ */
 31+
 32+/**
3033 * interface is intended to be more or less compatible with
3134 * the PHP memcached client.
3235 *
Index: trunk/phase3/includes/RecentChange.php
@@ -2,6 +2,7 @@
33
44 /**
55 * Utility class for creating new RC entries
 6+ *
67 * mAttribs:
78 * rc_id id of the row in the recentchanges table
89 * rc_timestamp time the entry was made
Index: trunk/phase3/includes/MimeMagic.php
@@ -1,9 +1,12 @@
22 <?php
3 -/** Module defining helper functions for detecting and dealing with mime types.
 3+/**
 4+ * Module defining helper functions for detecting and dealing with mime types.
45 *
 6+ * @file
57 */
68
7 - /** Defines a set of well known mime types
 9+/**
 10+ * Defines a set of well known mime types
811 * This is used as a fallback to mime.types files.
912 * An extensive list of well known mime types is provided by
1013 * the file mime.types in the includes directory.
@@ -50,7 +53,8 @@
5154 END_STRING
5255 );
5356
54 - /** Defines a set of well known mime info entries
 57+/**
 58+ * Defines a set of well known mime info entries
5559 * This is used as a fallback to mime.info files.
5660 * An extensive list of well known mime types is provided by
5761 * the file mime.info in the includes directory.
Index: trunk/phase3/includes/Exif.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Exif metadata reader
 5+ *
46 * This program is free software; you can redistribute it and/or modify
57 * it under the terms of the GNU General Public License as published by
68 * the Free Software Foundation; either version 2 of the License, or
Index: trunk/phase3/includes/proxy_check.php
@@ -1,6 +1,8 @@
22 <?php
33 /**
44 * Command line script to check for an open proxy at a specified location
 5+ *
 6+ * @file
57 */
68
79 if( php_sapi_name() != 'cli' ) {
Index: trunk/phase3/includes/Sanitizer.php
@@ -2,7 +2,7 @@
33 /**
44 * XHTML sanitizer for MediaWiki
55 *
6 - * Copyright (C) 2002-2005 Brion Vibber <brion@pobox.com> et al
 6+ * Copyright © 2002-2005 Brion Vibber <brion@pobox.com> et al
77 * http://www.mediawiki.org/
88 *
99 * This program is free software; you can redistribute it and/or modify
Index: trunk/phase3/includes/Hooks.php
@@ -1,6 +1,7 @@
22 <?php
33 /**
4 - * Hooks.php -- a tool for running hook functions
 4+ * A tool for running hook functions.
 5+ *
56 * Copyright 2004, 2005 Evan Prodromou <evan@wikitravel.org>.
67 *
78 * This program is free software; you can redistribute it and/or modify
@@ -24,9 +25,15 @@
2526
2627
2728 /**
 29+ * Call hook functions defined in $wgHooks
 30+ *
2831 * Because programmers assign to $wgHooks, we need to be very
2932 * careful about its contents. So, there's a lot more error-checking
3033 * in here than would normally be necessary.
 34+ *
 35+ * @param $event String: event name
 36+ * @param $args Array: parameters passed to hook functions
 37+ * @return Boolean
3138 */
3239 function wfRunHooks($event, $args = array()) {
3340
Index: trunk/phase3/includes/AutoLoader.php
@@ -1,9 +1,15 @@
22 <?php
3 -/* This defines autoloading handler for whole MediaWiki framework */
 3+/**
 4+ * This defines autoloading handler for whole MediaWiki framework
 5+ *
 6+ * @file
 7+ */
48
5 -# Locations of core classes
6 -# Extension classes are specified with $wgAutoloadClasses
7 -# This array is a global instead of a static member of AutoLoader to work around a bug in APC
 9+/**
 10+ * Locations of core classes
 11+ * Extension classes are specified with $wgAutoloadClasses
 12+ * This array is a global instead of a static member of AutoLoader to work around a bug in APC
 13+ */
814 global $wgAutoloadLocalClasses;
915
1016 $wgAutoloadLocalClasses = array(
Index: trunk/phase3/includes/AjaxFunctions.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Handler functions for Ajax requests
 5+ *
46 * @file
57 * @ingroup Ajax
68 */
Index: trunk/phase3/includes/MagicWord.php
@@ -1,6 +1,7 @@
22 <?php
33 /**
44 * File for magic words
 5+ *
56 * See docs/magicword.txt
67 *
78 * @file
Index: trunk/phase3/includes/ImportXMLReader.php
@@ -1,5 +1,11 @@
22 <?php
33 /**
 4+ * XML file reader for the page data importer
 5+ *
 6+ * @file
 7+ */
 8+
 9+/**
410 * implements Special:Import
511 * @ingroup SpecialPage
612 */
Index: trunk/phase3/includes/RawPage.php
@@ -1,7 +1,10 @@
22 <?php
33 /**
4 - * Copyright (C) 2004 Gabriel Wicke <wicke@wikidev.net>
 4+ * Raw page text accessor
 5+ *
 6+ * Copyright © 2004 Gabriel Wicke <wicke@wikidev.net>
57 * http://wikidev.net/
 8+ *
69 * Based on HistoryPage and SpecialExport
710 *
811 * License: GPL (http://www.gnu.org/copyleft/gpl.html)
Index: trunk/phase3/includes/SkinTemplate.php
@@ -1,22 +1,28 @@
22 <?php
 3+/**
 4+ * Base class for template-based skins
 5+ *
 6+ * This program is free software; you can redistribute it and/or modify
 7+ * it under the terms of the GNU General Public License as published by
 8+ * the Free Software Foundation; either version 2 of the License, or
 9+ * (at your option) any later version.
 10+ *
 11+ * This program is distributed in the hope that it will be useful,
 12+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 13+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 14+ * GNU General Public License for more details.
 15+ *
 16+ * You should have received a copy of the GNU General Public License along
 17+ * with this program; if not, write to the Free Software Foundation, Inc.,
 18+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 19+ * http://www.gnu.org/copyleft/gpl.html
 20+ *
 21+ * @file
 22+ */
 23+
324 if ( ! defined( 'MEDIAWIKI' ) )
425 die( 1 );
526
6 -# This program is free software; you can redistribute it and/or modify
7 -# it under the terms of the GNU General Public License as published by
8 -# the Free Software Foundation; either version 2 of the License, or
9 -# (at your option) any later version.
10 -#
11 -# This program is distributed in the hope that it will be useful,
12 -# but WITHOUT ANY WARRANTY; without even the implied warranty of
13 -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 -# GNU General Public License for more details.
15 -#
16 -# You should have received a copy of the GNU General Public License along
17 -# with this program; if not, write to the Free Software Foundation, Inc.,
18 -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 -# http://www.gnu.org/copyleft/gpl.html
20 -
2127 /**
2228 * Wrapper object for MediaWiki's localization functions,
2329 * to be passed to the template engine.
Index: trunk/phase3/includes/WikiError.php
@@ -1,7 +1,8 @@
22 <?php
33 /**
44 * MediaWiki error classes
5 - * Copyright (C) 2005 Brion Vibber <brion@pobox.com>
 5+ *
 6+ * Copyright © 2005 Brion Vibber <brion@pobox.com>
67 * http://www.mediawiki.org/
78 *
89 * This program is free software; you can redistribute it and/or modify
@@ -19,6 +20,7 @@
2021 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
2122 * http://www.gnu.org/copyleft/gpl.html
2223 *
 24+ * @file
2325 */
2426
2527 /**
Index: trunk/phase3/includes/Metadata.php
@@ -1,6 +1,7 @@
22 <?php
33 /**
4 - * Metadata.php -- provides DublinCore and CreativeCommons metadata
 4+ * Provides DublinCore and CreativeCommons metadata
 5+ *
56 * Copyright 2004, Evan Prodromou <evan@wikitravel.org>.
67 *
78 * This program is free software; you can redistribute it and/or modify
@@ -18,6 +19,7 @@
1920 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
2021 *
2122 * @author Evan Prodromou <evan@wikitravel.org>
 23+ * @file
2224 */
2325
2426 abstract class RdfMetaData {
Index: trunk/phase3/includes/Credits.php
@@ -1,22 +1,24 @@
22 <?php
33 /**
4 - * Credits.php -- formats credits for articles
 4+ * Formats credits for articles
 5+ *
56 * Copyright 2004, Evan Prodromou <evan@wikitravel.org>.
67 *
7 - * This program is free software; you can redistribute it and/or modify
8 - * it under the terms of the GNU General Public License as published by
9 - * the Free Software Foundation; either version 2 of the License, or
10 - * (at your option) any later version.
 8+ * This program is free software; you can redistribute it and/or modify
 9+ * it under the terms of the GNU General Public License as published by
 10+ * the Free Software Foundation; either version 2 of the License, or
 11+ * (at your option) any later version.
1112 *
12 - * This program is distributed in the hope that it will be useful,
13 - * but WITHOUT ANY WARRANTY; without even the implied warranty of
14 - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15 - * GNU General Public License for more details.
 13+ * This program is distributed in the hope that it will be useful,
 14+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 15+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 16+ * GNU General Public License for more details.
1617 *
17 - * You should have received a copy of the GNU General Public License
18 - * along with this program; if not, write to the Free Software
19 - * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
 18+ * You should have received a copy of the GNU General Public License
 19+ * along with this program; if not, write to the Free Software
 20+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA
2021 *
 22+ * @file
2123 * @author <evan@wikitravel.org>
2224 */
2325
Index: trunk/phase3/includes/Import.php
@@ -1,7 +1,8 @@
22 <?php
33 /**
44 * MediaWiki page data importer
5 - * Copyright (C) 2003,2005 Brion Vibber <brion@pobox.com>
 5+ *
 6+ * Copyright © 2003,2005 Brion Vibber <brion@pobox.com>
67 * http://www.mediawiki.org/
78 *
89 * This program is free software; you can redistribute it and/or modify
@@ -24,7 +25,7 @@
2526 */
2627
2728 /**
28 - *
 29+ * @todo document (e.g. one-sentence class description).
2930 * @ingroup SpecialPage
3031 */
3132 class WikiRevision {
Index: trunk/phase3/includes/RevisionDelete.php
@@ -1,5 +1,11 @@
22 <?php
33 /**
 4+ * Revision/log/file deletion backend
 5+ *
 6+ * @file
 7+ */
 8+
 9+/**
410 * Temporary b/c interface, collection of static functions.
511 * @ingroup SpecialPage
612 */
Index: trunk/phase3/includes/Exception.php
@@ -1,10 +1,17 @@
22 <?php
33 /**
 4+ * Exception class and handler
 5+ *
 6+ * @file
 7+ */
 8+
 9+/**
410 * @defgroup Exception Exception
511 */
612
713 /**
814 * MediaWiki exception
 15+ *
916 * @ingroup Exception
1017 */
1118 class MWException extends Exception {
Index: trunk/phase3/includes/AjaxResponse.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Response handler for Ajax requests
 5+ *
46 * @file
57 * @ingroup Ajax
68 */
Index: trunk/phase3/includes/IP.php
@@ -1,7 +1,10 @@
22 <?php
3 -/*
4 - * @Author "Ashar Voultoiz" <hashar@altern.org>
5 - * @License GPL v2 or later
 3+/**
 4+ * Functions and constants to play with IP addresses and ranges
 5+ *
 6+ * @file
 7+ * @author "Ashar Voultoiz" <hashar@altern.org>
 8+ * @license GPL v2 or later
69 */
710
811 // Some regex definition to "play" with IP address and IP address blocks
Index: trunk/phase3/includes/DjVuImage.php
@@ -1,8 +1,8 @@
22 <?php
3 -
43 /**
 4+ * DjVu image handler
55 *
6 - * Copyright (C) 2006 Brion Vibber <brion@pobox.com>
 6+ * Copyright © 2006 Brion Vibber <brion@pobox.com>
77 * http://www.mediawiki.org/
88 *
99 * This program is free software; you can redistribute it and/or modify
@@ -20,6 +20,7 @@
2121 * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
2222 * http://www.gnu.org/copyleft/gpl.html
2323 *
 24+ * @file
2425 */
2526
2627 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r70700Seems I forgot to commit these files in r70699ialex14:28, 8 August 2010

Status & tagging log