r70692 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70691‎ | r70692 | r70693 >
Date:13:12, 8 August 2010
Author:demon
Status:ok
Tags:
Comment:
Kill the last references to the Namespace class (they were comments)
Modified paths:
  • /trunk/extensions/ImageTagging/ImageTagging_body.php (modified) (history)
  • /trunk/extensions/Wikidata/php-tools/DataImport.php (modified) (history)

Diff [purge]

Index: trunk/extensions/ImageTagging/ImageTagging_body.php
@@ -205,8 +205,8 @@
206206 continue;
207207 }
208208
209 - // TODO
210 - // $ul = $sk->makeLink( $wgContLang->getNsText( Namespace::getUser() ) . ":{$ut}", $ut );
 209+ // TODO - getUser() doesn't exist, do you mean NS_USER?
 210+ // $ul = $sk->makeLink( $wgContLang->getNsText( MWNamespace::getUser() ) . ":{$ut}", $ut );
211211
212212 $nb = '';
213213 $textlink = $this->mShowFilename ?
Index: trunk/extensions/Wikidata/php-tools/DataImport.php
@@ -86,7 +86,7 @@
8787 echo "\nImporting Swiss-Prot\n";
8888 # $nsstore=wfGetNamespaceStore();
8989 # print_r($nsstore->nsarray);
90 -# "Namespace id for expression=" . Namespace::getIndexForName('expression');
 90+# "Namespace id for expression=" . MWNamespace::getIndexForName('expression');
9191
9292 // $umlsImport = new UMLSImportResult;
9393 // $umlsImport->umlsCollectionId = 5;

Follow-up revisions

RevisionCommit summaryAuthorDate
r70693Kill NamespaceCompat. Nothing, anywhere (not even comments, since r70692) sti...demon13:16, 8 August 2010

Status & tagging log