r70684 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70683‎ | r70684 | r70685 >
Date:11:55, 8 August 2010
Author:ialex
Status:resolved
Tags:
Comment:
* standardised file headers
* added a basic description
* added @file
Modified paths:
  • /trunk/phase3/includes/db/LBFactory.php (modified) (history)
  • /trunk/phase3/includes/db/LBFactory_Multi.php (modified) (history)
  • /trunk/phase3/includes/db/LoadBalancer.php (modified) (history)
  • /trunk/phase3/includes/db/LoadMonitor.php (modified) (history)
  • /trunk/phase3/includes/diff/Diff.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceEngine.php (modified) (history)
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)
  • /trunk/phase3/includes/extauth/Hardcoded.php (modified) (history)
  • /trunk/phase3/includes/extauth/MediaWiki.php (modified) (history)
  • /trunk/phase3/includes/extauth/vB.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/db/LBFactory_Multi.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Advanced database load balancing for wiki farms
 5+ *
46 * @file
57 * @ingroup Database
68 */
Index: trunk/phase3/includes/db/LBFactory.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Database load balancing
 5+ *
46 * @file
57 * @ingroup Database
68 */
Index: trunk/phase3/includes/db/LoadBalancer.php
@@ -1,5 +1,7 @@
22 <?php
33 /**
 4+ * Database load balancing
 5+ *
46 * @file
57 * @ingroup Database
68 */
Index: trunk/phase3/includes/db/LoadMonitor.php
@@ -1,9 +1,16 @@
22 <?php
 3+/**
 4+ * Database load monitoring
 5+ *
 6+ * @file
 7+ * @ingroup Database
 8+ */
39
410 /**
511 * An interface for database load monitoring
 12+ *
 13+ * @ingroup Database
614 */
7 -
815 interface LoadMonitor {
916 /**
1017 * Construct a new LoadMonitor with a given LoadBalancer parent
@@ -46,8 +53,9 @@
4754 /**
4855 * Basic MySQL load monitor with no external dependencies
4956 * Uses memcached to cache the replication lag for a short time
 57+ *
 58+ * @ingroup Database
5059 */
51 -
5260 class LoadMonitor_MySQL implements LoadMonitor {
5361 var $parent; // LoadBalancer
5462
Index: trunk/phase3/includes/diff/Diff.php
@@ -1,6 +1,9 @@
22 <?php
3 -/* Copyright (C) 2008 Guy Van den Broeck <guy@guyvdb.eu>
 3+/**
 4+ * New version of the difference engine
45 *
 6+ * Copyright © 2008 Guy Van den Broeck <guy@guyvdb.eu>
 7+ *
58 * This program is free software; you can redistribute it and/or modify
69 * it under the terms of the GNU General Public License as published by
710 * the Free Software Foundation; either version 2 of the License, or
@@ -15,6 +18,9 @@
1619 * along with this program; if not, write to the Free Software
1720 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
1821 * http://www.gnu.org/copyleft/gpl.html
 22+ *
 23+ * @file
 24+ * @ingroup DifferenceEngine
1925 */
2026
2127 /**
Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -1,6 +1,9 @@
22 <?php
33 /**
4 - * @defgroup DifferenceEngine DifferenceEngine
 4+ * User interface for the difference engine
 5+ *
 6+ * @file
 7+ * @ingroup DifferenceEngine
58 */
69
710 /**
Index: trunk/phase3/includes/diff/DifferenceEngine.php
@@ -1,14 +1,15 @@
22 <?php
33 /**
 4+ * A PHP diff engine for phpwiki. (Taken from phpwiki-1.3.3)
 5+ *
 6+ * Copyright © 2000, 2001 Geoffrey T. Dairiki <dairiki@dairiki.org>
 7+ * You may copy this code freely under the conditions of the GPL.
 8+ *
 9+ * @file
 10+ * @ingroup DifferenceEngine
411 * @defgroup DifferenceEngine DifferenceEngine
512 */
613
7 -// A PHP diff engine for phpwiki. (Taken from phpwiki-1.3.3)
8 -//
9 -// Copyright (C) 2000, 2001 Geoffrey T. Dairiki <dairiki@dairiki.org>
10 -// You may copy this code freely under the conditions of the GPL.
11 -//
12 -
1314 /**
1415 * @todo document
1516 * @private
Index: trunk/phase3/includes/extauth/Hardcoded.php
@@ -1,22 +1,27 @@
22 <?php
 3+/**
 4+ * External authentication with hardcoded user names and passwords
 5+ *
 6+ * Copyright © 2009 Aryeh Gregor
 7+ *
 8+ * This program is free software; you can redistribute it and/or modify
 9+ * it under the terms of the GNU General Public License as published by
 10+ * the Free Software Foundation; either version 2 of the License, or
 11+ * (at your option) any later version.
 12+ *
 13+ * This program is distributed in the hope that it will be useful,
 14+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 15+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 16+ * GNU General Public License for more details.
 17+ *
 18+ * You should have received a copy of the GNU General Public License along
 19+ * with this program; if not, write to the Free Software Foundation, Inc.,
 20+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 21+ * http://www.gnu.org/copyleft/gpl.html
 22+ *
 23+ * @file
 24+ */
325
4 -# Copyright (C) 2009 Aryeh Gregor
5 -#
6 -# This program is free software; you can redistribute it and/or modify
7 -# it under the terms of the GNU General Public License as published by
8 -# the Free Software Foundation; either version 2 of the License, or
9 -# (at your option) any later version.
10 -#
11 -# This program is distributed in the hope that it will be useful,
12 -# but WITHOUT ANY WARRANTY; without even the implied warranty of
13 -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 -# GNU General Public License for more details.
15 -#
16 -# You should have received a copy of the GNU General Public License along
17 -# with this program; if not, write to the Free Software Foundation, Inc.,
18 -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 -# http://www.gnu.org/copyleft/gpl.html
20 -
2126 /**
2227 * This class supports external authentication from a literal array dumped in
2328 * LocalSettings.php. It's mostly useful for testing. Example configuration:
Index: trunk/phase3/includes/extauth/MediaWiki.php
@@ -1,22 +1,27 @@
22 <?php
 3+/**
 4+ * External authentication with external MediaWiki database.
 5+ *
 6+ * Copyright © 2009 Aryeh Gregor
 7+ *
 8+ * This program is free software; you can redistribute it and/or modify
 9+ * it under the terms of the GNU General Public License as published by
 10+ * the Free Software Foundation; either version 2 of the License, or
 11+ * (at your option) any later version.
 12+ *
 13+ * This program is distributed in the hope that it will be useful,
 14+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 15+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 16+ * GNU General Public License for more details.
 17+ *
 18+ * You should have received a copy of the GNU General Public License along
 19+ * with this program; if not, write to the Free Software Foundation, Inc.,
 20+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 21+ * http://www.gnu.org/copyleft/gpl.html
 22+ *
 23+ * @file
 24+ */
325
4 -# Copyright (C) 2009 Aryeh Gregor
5 -#
6 -# This program is free software; you can redistribute it and/or modify
7 -# it under the terms of the GNU General Public License as published by
8 -# the Free Software Foundation; either version 2 of the License, or
9 -# (at your option) any later version.
10 -#
11 -# This program is distributed in the hope that it will be useful,
12 -# but WITHOUT ANY WARRANTY; without even the implied warranty of
13 -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 -# GNU General Public License for more details.
15 -#
16 -# You should have received a copy of the GNU General Public License along
17 -# with this program; if not, write to the Free Software Foundation, Inc.,
18 -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 -# http://www.gnu.org/copyleft/gpl.html
20 -
2126 /**
2227 * This class supports authentication against an external MediaWiki database,
2328 * probably any version back to 1.5 or something. Example configuration:
Index: trunk/phase3/includes/extauth/vB.php
@@ -1,22 +1,27 @@
22 <?php
 3+/**
 4+ * External authentication with a vBulletin database.
 5+ *
 6+ * Copyright © 2009 Aryeh Gregor
 7+ *
 8+ * This program is free software; you can redistribute it and/or modify
 9+ * it under the terms of the GNU General Public License as published by
 10+ * the Free Software Foundation; either version 2 of the License, or
 11+ * (at your option) any later version.
 12+ *
 13+ * This program is distributed in the hope that it will be useful,
 14+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
 15+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
 16+ * GNU General Public License for more details.
 17+ *
 18+ * You should have received a copy of the GNU General Public License along
 19+ * with this program; if not, write to the Free Software Foundation, Inc.,
 20+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
 21+ * http://www.gnu.org/copyleft/gpl.html
 22+ *
 23+ * @file
 24+ */
325
4 -# Copyright (C) 2009 Aryeh Gregor
5 -#
6 -# This program is free software; you can redistribute it and/or modify
7 -# it under the terms of the GNU General Public License as published by
8 -# the Free Software Foundation; either version 2 of the License, or
9 -# (at your option) any later version.
10 -#
11 -# This program is distributed in the hope that it will be useful,
12 -# but WITHOUT ANY WARRANTY; without even the implied warranty of
13 -# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14 -# GNU General Public License for more details.
15 -#
16 -# You should have received a copy of the GNU General Public License along
17 -# with this program; if not, write to the Free Software Foundation, Inc.,
18 -# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
19 -# http://www.gnu.org/copyleft/gpl.html
20 -
2126 /**
2227 * This class supports the proprietary vBulletin forum system
2328 * <http://www.vbulletin.com>, versions 3.5 and up. It calls no functions or

Follow-up revisions

RevisionCommit summaryAuthorDate
r70685Fix for r70684: correct descriptionialex12:09, 8 August 2010

Status & tagging log