r70582 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70581‎ | r70582 | r70583 >
Date:18:55, 6 August 2010
Author:tparscal
Status:ok
Tags:
Comment:
Using wfAppendQuery instead of http_build_query, also tried to support 'true' and 'false' as well as 1 and 0 - I think we need a better strategy, these conversions are getting complex and confusing.
Modified paths:
  • /branches/resourceloader/phase3/includes/OutputPage.php (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/includes/OutputPage.php
@@ -2183,9 +2183,12 @@
21842184 'modules' => implode( '|', $modules ),
21852185 'user' => $wgUser->isLoggedIn(),
21862186 'lang' => $wgLang->getCode(),
2187 - 'debug' => ( $wgRequest->getVal( 'debug' ) === 'true' ),
 2187+ 'debug' => (
 2188+ $wgRequest->getVal( 'debug' ) === 'true' ||
 2189+ ( $wgRequest->getVal( 'debug' ) !== 'false' && $wgRequest->getBool( 'debug' ) )
 2190+ ),
21882191 );
2189 - return Html::linkedScript( "{$wgScriptPath}/load.php?" . http_build_query( $query ) );
 2192+ return Html::linkedScript( wfAppendQuery( $wgScriptPath . 'load.php', $query );
21902193 }
21912194
21922195 /**

Follow-up revisions

RevisionCommit summaryAuthorDate
r70598Fixed missing ( introduced in r70582tparscal21:20, 6 August 2010

Status & tagging log