r70562 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70561‎ | r70562 | r70563 >
Date:13:30, 6 August 2010
Author:demon
Status:deferred
Tags:
Comment:
Kill last two uses of long-deprecated User::isBot()
Modified paths:
  • /trunk/extensions/AssertEdit/AssertEdit_body.php (modified) (history)
  • /trunk/extensions/MWReleases/MWReleases.i18n.php (modified) (history)
  • /trunk/extensions/MWReleases/MWReleases.php (modified) (history)
  • /trunk/extensions/SecurePoll/includes/user/Auth.php (modified) (history)

Diff [purge]

Index: trunk/extensions/MWReleases/MWReleases.i18n.php
@@ -10,9 +10,8 @@
1111 */
1212 $messages['en'] = array(
1313 'mwreleases-desc' => 'Adds a [[Mediawiki:Mwreleases-list|list]] of supported releases, accessible via the API',
14 - 'mwreleases-list' => '# List the current and other active supported MediaWiki releases like this:
15 -# current:1.15.1
16 -# supported:1.14.1'
 14+ 'releasemanager' => 'Release manager',
 15+ 'releasemanager-header' => 'Manage the MediaWiki release list. Create a new release or manage the current ones',
1716 );
1817
1918 /** Message documentation (Message documentation)
Index: trunk/extensions/MWReleases/MWReleases.php
@@ -42,6 +42,18 @@
4343 );
4444
4545 $dir = dirname( __FILE__ ) . '/';
 46+
 47+$wgAutoloadClasses['MWReleases'] = $dir . 'MWReleases_body.php';
4648 $wgAutoloadClasses['ApiMWReleases'] = $dir . 'ApiMWReleases.php';
 49+$wgAutoloadClasses['SpecialMediawikiReleases'] = $dir . 'SpecialMediawikiReleases.php';
 50+$wgAutoloadClasses['SpecialReleaseManager'] = $dir . 'SpecialReleaseManager.php';
 51+$wgAutoloadClasses['MWReleasesHooks'] = $dir . 'MWReleases.hooks.php';
4752 $wgExtensionMessagesFiles['MWReleases'] = $dir . 'MWReleases.i18n.php';
 53+$wgExtensionAliasesFiles['MWReleases'] = $dir . 'MWReleases.alias.php';
 54+
 55+$wgSpecialPages['MediawikiReleases'] = 'SpecialMediawikiReleases';
 56+$wgSpecialPages['ReleaseManager'] = 'SpecialReleaseManager';
4857 $wgAPIModules['mwreleases'] = 'ApiMWReleases';
 58+$wgHooks['LoadExtensionSchemaUpdates'][] = 'MWReleasesHooks::onLoadExtensionSchemaUpdates';
 59+$wgHooks['ParserFirstCallInit'][] = 'MWReleasesHooks::onParserFirstCallInit';
 60+$wgAvailableRights[] = 'releasemanager';
\ No newline at end of file
Index: trunk/extensions/AssertEdit/AssertEdit_body.php
@@ -13,7 +13,7 @@
1414 }
1515 static function assert_bot() {
1616 global $wgUser;
17 - return $wgUser->isBot();
 17+ return $wgUser->isAllowed( 'bot' );
1818 }
1919 static function assert_exists() {
2020 global $wgTitle;
Index: trunk/extensions/SecurePoll/includes/user/Auth.php
@@ -210,7 +210,7 @@
211211 'wiki' => wfWikiID(),
212212 'blocked' => $user->isBlocked(),
213213 'edit-count' => $user->getEditCount(),
214 - 'bot' => $user->isBot(),
 214+ 'bot' => $user->isAllowed( 'bot' ),
215215 'language' => $user->getOption( 'language' ),
216216 'groups' => $user->getGroups(),
217217 'lists' => $this->getLists( $user )

Follow-up revisions

RevisionCommit summaryAuthorDate
r70564Partial revert r70562, remove half-baked changesdemon13:40, 6 August 2010

Status & tagging log