r70559 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70558‎ | r70559 | r70560 >
Date:13:07, 6 August 2010
Author:demon
Status:ok
Tags:
Comment:
(bug 22514) SpecialRecentChangesQuery should also work on Special:RecentChangesLinked. Commented since inception, no reason not to call it here as well. Need this for FlaggedRevs stuff later anyway ;-)
Modified paths:
  • /trunk/phase3/docs/hooks.txt (modified) (history)
  • /trunk/phase3/includes/specials/SpecialRecentchangeslinked.php (modified) (history)

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
@@ -1554,7 +1554,7 @@
15551555 $opts: FormOptions for this request
15561556
15571557 'SpecialRecentChangesQuery': called when building sql query for
1558 -SpecialRecentChanges
 1558+SpecialRecentChanges and SpecialRecentChangesLinked
15591559 &$conds: array of WHERE conditionals for query
15601560 &$tables: array of tables to be queried
15611561 &$join_conds: join conditions for the tables
Index: trunk/phase3/includes/specials/SpecialRecentchangeslinked.php
@@ -109,8 +109,8 @@
110110 $query_options, $opts['tagfilter'] );
111111 }
112112
113 - // XXX: parent class does this, should we too?
114 - // wfRunHooks('SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts ) );
 113+ if ( !wfRunHooks( 'SpecialRecentChangesQuery', array( &$conds, &$tables, &$join_conds, $opts, &$query_options ) ) )
 114+ return false;
115115
116116 if( $ns == NS_CATEGORY && !$showlinkedto ) {
117117 // special handling for categories

Follow-up revisions

RevisionCommit summaryAuthorDate
r76485MFT r70559, r71970demon23:13, 10 November 2010
r76679MFT r70559, r71970 (SpecialRecentChangesQuery changes)robla08:34, 15 November 2010

Status & tagging log