r70557 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70556‎ | r70557 | r70558 >
Date:12:15, 6 August 2010
Author:catrope
Status:ok (Comments)
Tags:
Comment:
(bug 24665) When starttimestamp is not specified, fake it by setting it to NOW, not to the timestamp of the last edit. This caused 'pagedeleted' errors for pages that were deleted then partially undeleted that could only be gotten rid of by setting starttimestamp, while the docs claim not setting starttimestamp causes all such errors to be silenced
Modified paths:
  • /trunk/phase3/includes/api/ApiEditPage.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/api/ApiEditPage.php
——@@ -172,7 +172,7 @@
173173 if ( !is_null( $params['starttimestamp'] ) && $params['starttimestamp'] != '' ) {
174174 $reqArr['wpStarttime'] = wfTimestamp( TS_MW, $params['starttimestamp'] );
175175 } else {
176 - $reqArr['wpStarttime'] = $reqArr['wpEdittime']; // Fake wpStartime
 176+ $reqArr['wpStarttime'] = wfTimestampNow(); // Fake wpStartime
177177 }
178178
179179 if ( $params['minor'] ) {

Follow-up revisions

RevisionCommit summaryAuthorDate
r70560RELEASE-NOTES for r70557reedy13:28, 6 August 2010

Comments

#Comment by Bryan (talk | contribs)   19:24, 10 September 2010

I'm not too happy about errors passing silently, but if that's what the docs claimed then I guess it's ok.

Status & tagging log