r70515 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70514‎ | r70515 | r70516 >
Date:18:26, 5 August 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Remove unused fourth parameter for message cache constructor
Modified paths:
  • /trunk/phase3/includes/MessageCache.php (modified) (history)
  • /trunk/phase3/maintenance/parserTests.inc (modified) (history)
  • /trunk/phase3/maintenance/tests/UploadFromUrlTestSuite.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/parserTests.inc
@@ -759,7 +759,7 @@
760760
761761 # Make a new message cache
762762 global $wgMessageCache, $wgMemc;
763 - $wgMessageCache = new MessageCache( $wgMemc, true, 3600, '' );
 763+ $wgMessageCache = new MessageCache( $wgMemc, true, 3600 );
764764 }
765765
766766 /**
Index: trunk/phase3/maintenance/tests/UploadFromUrlTestSuite.php
@@ -54,7 +54,7 @@
5555
5656 $wgMessageCache = new StubObject( 'wgMessageCache', 'MessageCache',
5757 array( $messageMemc, $wgUseDatabaseMessages,
58 - $wgMsgCacheExpiry, wfWikiID() ) );
 58+ $wgMsgCacheExpiry ) );
5959 if ( $wgStyleDirectory === false ) $wgStyleDirectory = "$IP/skins";
6060
6161 }
Index: trunk/phase3/includes/MessageCache.php
@@ -27,7 +27,7 @@
2828 // Variable for tracking which variables are loaded
2929 var $mLoadedLanguages = array();
3030
31 - function __construct( $memCached, $useDB, $expiry, /*ignored*/ $memcPrefix ) {
 31+ function __construct( $memCached, $useDB, $expiry ) {
3232 if ( !$memCached ) {
3333 $memCached = wfGetCache( CACHE_NONE );
3434 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r70670Followup r70515, commiting forgotten filenikerabbit06:36, 8 August 2010

Status & tagging log