r70493 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70492‎ | r70493 | r70494 >
Date:08:12, 5 August 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
GROUP BY should have been ORDER BY

I somehow manage to mix them up always
Modified paths:
  • /trunk/extensions/Translate/MessageGroups.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/MessageGroups.php
@@ -757,7 +757,7 @@
758758 $conds = array( 'trs_page' => $this->getTitle()->getArticleId() );
759759 $options = array();
760760 if ( $dbr->fieldExists( 'translate_sections', 'trs_order', __METHOD__ ) ) {
761 - $options['GROUP BY'] = 'trs_order';
 761+ $options['ORDER BY'] = 'trs_order';
762762 }
763763 $res = $dbr->select( $tables, $vars, $conds, __METHOD__, $options );
764764

Status & tagging log