r70494 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70493‎ | r70494 | r70495 >
Date:08:24, 5 August 2010
Author:nad
Status:deferred
Tags:
Comment:
remove ref symbol from passed string args in hook
Modified paths:
  • /trunk/extensions/CategoryWatch/CategoryWatch.php (modified) (history)

Diff [purge]

Index: trunk/extensions/CategoryWatch/CategoryWatch.php
@@ -14,7 +14,7 @@
1515 * @licence GNU General Public Licence 2.0 or later
1616 */
1717
18 -define( 'CATEGORYWATCH_VERSION', '1.2.0, 2010-07-15' );
 18+define( 'CATEGORYWATCH_VERSION', '1.2.1, 2010-08-05' );
1919
2020 # Whether or not to also send notificaton to the person who made the change
2121 $wgCategoryWatchNotifyEditor = true;
@@ -48,7 +48,7 @@
4949 /**
5050 * Get a list of categories before article updated
5151 */
52 - function onArticleSave( &$article, &$user, &$text ) {
 52+ function onArticleSave( &$article, &$user, $text ) {
5353 global $wgCategoryWatchUseAutoCat, $wgCategoryWatchUseAutoCatRealName;
5454
5555 $this->before = array();
@@ -86,7 +86,7 @@
8787 /**
8888 * Find changes in categorisation and send messages to watching users
8989 */
90 - function onArticleSaveComplete( &$article, &$user, &$text, &$summary, &$medit ) {
 90+ function onArticleSaveComplete( &$article, &$user, $text, $summary, $medit ) {
9191
9292 # Get cats after update
9393 $this->after = array();

Follow-up revisions

RevisionCommit summaryAuthorDate
r70495Merging with trunk r70494peter1709:30, 5 August 2010
r70574updaters.inc broken in my previous commit; committing the version of r70494peter1715:57, 6 August 2010

Status & tagging log