r70482 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70481‎ | r70482 | r70483 >
Date:21:47, 4 August 2010
Author:simetrical
Status:ok (Comments)
Tags:
Comment:
"$something ? false : true" is silly.

Note: not actually tested, but it's really hard to see how it will
fail . . . really!
Modified paths:
  • /trunk/phase3/includes/GlobalFunctions.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/GlobalFunctions.php
——@@ -572,7 +572,7 @@
573573 */
574574 function wfUILang() {
575575 global $wgBetterDirectionality;
576 - return wfGetLangObj( $wgBetterDirectionality ? false: true );
 576+ return wfGetLangObj( !$wgBetterDirectionality );
577577 }
578578
579579 /**

Comments

#Comment by Reedy (talk | contribs)   22:01, 4 August 2010

Manual:$wgBetterDirectionality might be worth creating :)

#Comment by 😂 (talk | contribs)   11:54, 5 August 2010

Not tested?!? Suggest immediate revert.

Status & tagging log