r70433 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70432‎ | r70433 | r70434 >
Date:22:13, 3 August 2010
Author:platonides
Status:ok
Tags:
Comment:
Use Disabled for the value 0 of stub threshold since there seems to be some confusion on how to disable it.
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -583,8 +583,8 @@
584584 );
585585 }
586586
587 - $stubThresholdValues = array( 0, 50, 100, 500, 1000, 2000, 5000, 10000 );
588 - $stubThresholdOptions = array();
 587+ $stubThresholdValues = array( 50, 100, 500, 1000, 2000, 5000, 10000 );
 588+ $stubThresholdOptions = array( wfMsg( 'stub-threshold-disabled' ) => 0 );
589589 foreach ( $stubThresholdValues as $value ) {
590590 $stubThresholdOptions[wfMsg( 'size-bytes', $value )] = $value;
591591 }
Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -1751,6 +1751,7 @@
17521752 'contextlines' => 'Lines per hit:',
17531753 'contextchars' => 'Context per line:',
17541754 'stub-threshold' => 'Threshold for <a href="#" class="stub">stub link</a> formatting (bytes):',
 1755+'stub-threshold-disabled' => 'Disabled',
17551756 'recentchangesdays' => 'Days to show in recent changes:',
17561757 'recentchangesdays-max' => 'Maximum $1 {{PLURAL:$1|day|days}}',
17571758 'recentchangescount' => 'Number of edits to show by default:',

Follow-up revisions

RevisionCommit summaryAuthorDate
r70434http://www.mediawiki.org/wiki/User:Catrope/Stub_threshold shows us people set...platonides22:32, 3 August 2010
r70451Folloow-up r70433: Add new message key to maintenance scriptraymond07:52, 4 August 2010

Status & tagging log