r70263 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70262‎ | r70263 | r70264 >
Date:08:43, 1 August 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Fix incorrect call. Spotted by MaxSem and reported on CR.
Modified paths:
  • /trunk/extensions/Translate/SpecialTranslationChanges.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/SpecialTranslationChanges.php
——@@ -120,7 +120,7 @@
121121 $index = -1;
122122 $output = '';
123123 $skin = $wgUser->getSkin();
124 - $userLang = $wgUser->getCode;
 124+ $userLang = $wgLang->getCode();
125125
126126 $changes = $this->sort( $rows );
127127 foreach ( $changes as $class => $groups ) {

Comments

#Comment by Nikerabbit (talk | contribs)   15:20, 1 August 2010

It's a good idea to include the revision you fixed in the commit. Otherwise if someone looks at the old revision now, they assume it's not fixed.

#Comment by TheDJ (talk | contribs)   15:21, 1 August 2010

It seems r70259

Status & tagging log