r70220 MediaWiki - Code Review archive

In Resources.php:

'jquery.ui.datepicker' => array(
        [...]
        'locales' => array(
                'af' => 'resources/jquery/ui/i18n/jquery.ui.datepicker-af.js',
                [...]
        ),
),
[...]
// i18n
'jquery.ui.datepicker-af' => array( 'script' => 'resources/jquery/ui/i18n/jquery.ui.datepicker-af.js' ),

Do we really need to include these modules twice like this?

In mediawiki.js:

- 	                                 for ( var k = 0; k < keys.length; k++ ) {
+ 	                                 for ( var k  in keys ) {

When doing this, make extra special sure that keys really is an object rather than array. Your usage in set() looks good, but the one in get() looks suspect.

-        	                        for ( var argKey in args ) {
-	                                         msg = msg.replace( '\$' + ( parseInt( argKey ) + 1 ), args[argKey] );
+	                                for ( var a = 0; a < args.length; a++ ) {
+ 	                                         msg = msg.replace( '\$' + ( parseInt( a ) + 1 ), args[a] );

As I said in a previous CR comment, this will break for e.g. $10. Moreover, it will not catch repeated instances of $1 (which are legal, and occasionally used) because you're not using a regex with the /g modifier.

First issue addressed in r70365

Fixes for issue 2 in r70469.