r70190 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70189‎ | r70190 | r70191 >
Date:06:48, 30 July 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Stylize.php for remaining messages files.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesBpy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBqi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesBs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCeb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCkb_arab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCrh_cyrl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCrh_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesCy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDe_formal.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDiq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesDz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesEu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesExt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFf.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFrp.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFrr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFur.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesFy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGag.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGan_hans.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGan_hant.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGd.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGsw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesGv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHak.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHif_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHil.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHsb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesHu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesId.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesIt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesJut.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesJv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKaa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKiu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKk_arab.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKk_cyrl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKk_latn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKm.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKoi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKrc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesKsh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLa.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLad.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLb.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLfn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLi.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLij.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLmo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLoz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLzh.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesLzz.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMai.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMdf.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMg.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMk.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMr.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMrj.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMs.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMwl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMy.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesMyv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNah.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNds.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNds_nl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNe.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNew.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNl.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNl_informal.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesNso.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesOc.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesPt_br.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSli.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSn.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSo.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSr_ec.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSr_el.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesStq.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSu.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSv.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSw.php (modified) (history)
  • /trunk/phase3/languages/messages/MessagesSzl.php (modified) (history)

Comments

#Comment by Hashar (talk | contribs)   11:34, 25 October 2010

I am not going to review yet another stylizing commit, specially when viewvc is unable to show the diffs :p

Marking 'defered' since nobody will ever look at it (or I owe you a beer).

#Comment by Siebrand (talk | contribs)   16:02, 26 October 2010

The beer is welcome, but Reedy (IIRC) and I did some careful review on this, and I agree further review is not needed.

#Comment by Hashar (talk | contribs)   20:06, 26 October 2010

marked ok since it got reviewed. Hopefully I will come at the next meeting :-)

#Comment by Reedy (talk | contribs)   16:05, 26 October 2010

It probably was me, as I was poking at stylizing various things =D

Status & tagging log