r70179 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70178‎ | r70179 | r70180 >
Date:22:03, 29 July 2010
Author:nikerabbit
Status:ok
Tags:
Comment:
Made the variables check actually do what it says.

We likely need another check for plurals?
Modified paths:
  • /trunk/extensions/Translate/groups/FUDforum/Checker.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Translate/groups/FUDforum/Checker.php
@@ -19,7 +19,7 @@
2020 $definition = $message->definition();
2121 $translation = $message->translation();
2222
23 - $varPattern = '{(?!PLURAL).*}';
 23+ $varPattern = '\$[1-9]';
2424 preg_match_all( "/$varPattern/U", $definition, $defVars );
2525 preg_match_all( "/$varPattern/U", $translation, $transVars );
2626

Status & tagging log