r70161 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r70160‎ | r70161 | r70162 >
Date:18:39, 29 July 2010
Author:tparscal
Status:ok (Comments)
Tags:
Comment:
Now window.MediaWiki is the cononical name for the mw object, but window.mw points there too.
Modified paths:
  • /branches/resourceloader/phase3/resources/mw/mw.js (modified) (history)

Diff [purge]

Index: branches/resourceloader/phase3/resources/mw/mw.js
——@@ -747,5 +747,5 @@
748748 };
749749 } )();
750750 // Attach to window
751 - window.mw = $.extend( 'mw' in window ? window.mw : {}, this );
 751+ window.MediaWiki = window.mw = $.extend( 'mw' in window ? window.mw : {}, this );
752752 } )();
\ No newline at end of file

Comments

#Comment by Catrope (talk | contribs)   13:43, 4 August 2010

Why window.MediaWiki instead of window.mediawiki? We never use CamelCase, only camelCase, for things that aren't class names.

Status & tagging log