r70059 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70058‎ | r70059 | r70060 >
Date:00:03, 28 July 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Revert r70058 per comment
Modified paths:
  • /trunk/extensions/FlaggedRevs/FlaggedRevs.class.php (modified) (history)

Diff [purge]

Index: trunk/extensions/FlaggedRevs/FlaggedRevs.class.php
@@ -531,16 +531,10 @@
532532 }
533533 }
534534 }
535 - # Parse the new body, wikitext -> html. Maybe use parser cache
536 - $options = self::makeParserOptions();
537 - $parserOut = null;
538 - if( $title->getLatestRevID() == $id ) {
539 - $parserOut = ParserCache::singleton()->get( new Article( $title, 0 ), $options );
540 - }
541 - if( !$parserOut ) {
542 - $parserOut = $wgParser->parse( $text, $title, $options, true, true, $id );
543 - }
544 -
 535+ # Parse the new body, wikitext -> html
 536+ $options = self::makeParserOptions(); // default options
 537+ $parserOut = $wgParser->parse( $text, $title, $options, true, true, $id );
 538+ # Stable parse done!
545539 if ( $resetManager ) {
546540 $incManager->clear(); // reset the FRInclusionManager as needed
547541 }

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r70058Make FlaggedRevs::parseStableText() use the parser cache if the rev id is als...demon23:05, 27 July 2010

Comments

#Comment by Aaron Schulz (talk | contribs)   00:13, 28 July 2010

If the current /trunk changes are not enough, then I'll use the patch I have.

Status & tagging log