r70025 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r70024‎ | r70025 | r70026 >
Date:18:34, 27 July 2010
Author:siebrand
Status:ok (Comments)
Tags:
Comment:
Update single quotes to double quotes for consistency.
Modified paths:
  • /trunk/phase3/languages/messages/MessagesEn.php (modified) (history)

Diff [purge]

Index: trunk/phase3/languages/messages/MessagesEn.php
@@ -2720,9 +2720,9 @@
27212721 # Delete
27222722 'deletepage' => 'Delete page',
27232723 'confirm' => 'Confirm',
2724 -'excontent' => "content was: '$1'",
2725 -'excontentauthor' => "content was: '$1' (and the only contributor was '[[Special:Contributions/$2|$2]]')",
2726 -'exbeforeblank' => "content before blanking was: '$1'",
 2724+'excontent' => "content was: \"$1\"",
 2725+'excontentauthor' => "content was: \"$1\" (and the only contributor was \"[[Special:Contributions/$2|$2]]\")",
 2726+'exbeforeblank' => "content before blanking was: \"$1\"",
27272727 'exblank' => 'page was empty',
27282728 'delete-confirm' => 'Delete "$1"',
27292729 'delete-backlink' => '← $1', # only translate this message to other languages if you have to change it
@@ -4070,9 +4070,9 @@
40714071
40724072 # Auto-summaries
40734073 'autosumm-blank' => 'Blanked the page',
4074 -'autosumm-replace' => "Replaced content with '$1'",
 4074+'autosumm-replace' => "Replaced content with \"$1\"",
40754075 'autoredircomment' => 'Redirected page to [[$1]]',
4076 -'autosumm-new' => "Created page with '$1'",
 4076+'autosumm-new' => "Created page with \"$1\"",
40774077
40784078 # Autoblock whitelist
40794079 'autoblock_whitelist' => 'AOL http://webmaster.info.aol.com/proxyinfo.html

Comments

#Comment by Hashar (talk | contribs)   11:36, 25 October 2010

"content was: \"$1\"",

Is probably nicer as :

'content was: "$1"',

Or English people should adapt and Guillemets « » http://en.wikipedia.org/wiki/Guillemets :)

Marking 'ok'

Status & tagging log