r69834 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69833‎ | r69834 | r69835 >
Date:17:12, 24 July 2010
Author:avar
Status:ok (Comments)
Tags:
Comment:
overrideConfig was moved to CoreInstaller in r69738, but new-index.php / maintenance/install.php wasn't updated
Modified paths:
  • /trunk/phase3/config/new-index.php (modified) (history)
  • /trunk/phase3/maintenance/install.php (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/install.php
——@@ -20,7 +20,7 @@
2121 * @see wfWaitForSlaves()
2222 */
2323
24 -define( 'MW_CONFIG_CALLBACK', 'Installer::overrideConfig' );
 24+define( 'MW_CONFIG_CALLBACK', 'CoreInstaller::overrideConfig' );
2525
2626 require_once( dirname( dirname( __FILE__ ) )."/maintenance/Maintenance.php" );
2727
Index: trunk/phase3/config/new-index.php
——@@ -1,6 +1,6 @@
22 <?php
33
4 -define( 'MW_CONFIG_CALLBACK', 'Installer::overrideConfig' );
 4+define( 'MW_CONFIG_CALLBACK', 'CoreInstaller::overrideConfig' );
55
66 chdir( ".." );
77 require( './includes/WebStart.php' );

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69738Split Installer into Installer and CoreInstaller + made misc style and doc im...jeroendedauw17:58, 22 July 2010

Comments

#Comment by Ævar Arnfjörð Bjarmason (talk | contribs)   17:18, 24 July 2010

Marking my own commit as OK since jeroendedauw ok'd it on IRC. It was just a trivial "forgot to check in" mistake.

Status & tagging log