r69803 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69802‎ | r69803 | r69804 >
Date:17:30, 23 July 2010
Author:mah
Status:reverted (Comments)
Tags:
Comment:
re Catrope's comments on r69766 + the strict warnings:
* Back out all changes to WikiEditor
* LQT now uses the existing EditPageBeforeEditToolbar (that WikiEditor is already using) instead of providing its own hook.
Modified paths:
  • /trunk/extensions/LiquidThreads/classes/View.php (modified) (history)
  • /trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php (modified) (history)

Diff [purge]

Index: trunk/extensions/UsabilityInitiative/WikiEditor/WikiEditor.hooks.php
@@ -473,18 +473,6 @@
474474 return true;
475475 }
476476
477 - public static function addModulesForThread( $thread, $levelNum, $totalInLevel, $options ) {
478 - static $firstRun = true;
479 -
480 - if( $firstRun ) {
481 - $temp = null;
482 - WikiEditorHooks::addModules( $temp );
483 - $firstRun = false;
484 - }
485 -
486 - return true;
487 - }
488 -
489477 /**
490478 * GetPreferences hook
491479 * Add module-releated items to the preferences
Index: trunk/extensions/LiquidThreads/classes/View.php
@@ -1900,6 +1900,10 @@
19011901 $sk = $this->user->getSkin();
19021902 $html = '';
19031903
 1904+ if ( wfRunHooks( 'EditPageBeforeEditToolbar', array( $html ) ) ) {
 1905+ self::addJSandCSS();
 1906+ }
 1907+
19041908 $html .= Xml::openElement( 'div', array( 'class' => 'lqt-thread-wrapper' ) );
19051909
19061910 $html .= Xml::element( 'a', array( 'name' => $this->anchorName( $thread ) ), ' ' );
@@ -1958,10 +1962,6 @@
19591963 )
19601964 );
19611965
1962 - if ( wfRunHooks( 'LiquidThreadsShowThread', array( $thread, $levelNum, $totalInLevel, $options ) ) ) {
1963 - self::addJSandCSS();
1964 - }
1965 -
19661966 // Flush output to display thread
19671967 $this->output->addHTML( $html );
19681968 $this->output->addHTML( Xml::openElement( 'div',

Follow-up revisions

RevisionCommit summaryAuthorDate
r69804re r69803, r69766: remove where WikiEditor actually hooked into LQT.mah17:34, 23 July 2010
r70076LiquidThreads: revert r69766 and friends r69774, r69803, r69804. Broken, and ...werdna10:36, 28 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69766* Consolidate instances of LqtView::addJSandCSS() and eliminate one (apparent...mah22:54, 22 July 2010

Comments

#Comment by Werdna (talk | contribs)   10:22, 28 July 2010

Another apparently untested revision. I get a MediaWiki exception and a PHP warning when viewing a LiquidThreads talk page.

Status & tagging log