r69681 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69680‎ | r69681 | r69682 >
Date:14:16, 21 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Double quotes instead of single ones
Modified paths:
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsQP.php
@@ -40,7 +40,7 @@
4141 addOnloadHook(
4242 function() {
4343 initializeYahooMap(
44 - '$mapName',
 44+ "$mapName",
4545 $this->centreLat,
4646 $this->centreLon,
4747 $this->zoom,
Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php
@@ -73,8 +73,8 @@
7474 addOnloadHook(
7575 function() {
7676 makeFormInputYahooMap(
77 - '$mapName',
78 - '$this->coordsFieldName',
 77+ "$mapName",
 78+ "$this->coordsFieldName",
7979 $this->centreLat,
8080 $this->centreLon,
8181 $this->zoom,
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersQP.php
@@ -47,14 +47,14 @@
4848 addOnloadHook(
4949 function() {
5050 initOpenLayer(
51 - '$mapName',
 51+ "$mapName",
5252 $this->centreLat,
5353 $this->centreLon,
5454 $this->zoom,
5555 [$layerItems],
5656 [$this->controls],
5757 $this->markerJs,
58 - '$langCode'
 58+ "$langCode"
5959 );
6060 }
6161 );
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php
@@ -67,8 +67,8 @@
6868 addOnloadHook(
6969 function() {
7070 makeFormInputOpenLayer(
71 - '$mapName',
72 - '$this->coordsFieldName',
 71+ "$mapName",
 72+ "$this->coordsFieldName",
7373 $this->centreLat,
7474 $this->centreLon,
7575 $this->zoom,
@@ -76,7 +76,7 @@
7777 {$this->markerCoords['lon']},
7878 [$layerItems],
7979 [$this->controls],
80 - '$langCode'
 80+ "$langCode"
8181 );
8282 }
8383 );
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsQP.php
@@ -60,7 +60,7 @@
6161 $this->service->addDependency( Html::inlineScript( <<<EOT
6262 addOnloadHook(
6363 function() {
64 - initializeGoogleMap('$mapName',
 64+ initializeGoogleMap("$mapName",
6565 {
6666 lat: $this->centreLat,
6767 lon: $this->centreLon,
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -83,8 +83,8 @@
8484 addOnloadHook(
8585 function() {
8686 makeGoogleMapFormInput(
87 - '$mapName',
88 - '$this->coordsFieldName',
 87+ "$mapName",
 88+ "$this->coordsFieldName",
8989 {
9090 lat: $this->centreLat,
9191 lon: $this->centreLon,

Status & tagging log