r69680 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69679‎ | r69680 | r69681 >
Date:14:16, 21 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Double quotes instead of single ones
Modified paths:
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMapsDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3DispMap.php (modified) (history)
  • /trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3DispPoint.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispMap.php (modified) (history)
  • /trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispPoint.php (modified) (history)
  • /trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMapsDispMap.php (modified) (history)
  • /trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMapsDispPoint.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3DispPoint.php
@@ -43,7 +43,7 @@
4444 addOnloadHook(
4545 function() {
4646 initGMap3(
47 - '$mapName',
 47+ "$mapName",
4848 {
4949 zoom: $this->zoom,
5050 lat: $this->centreLat,
Index: trunk/extensions/Maps/Services/GoogleMaps3/Maps_GoogleMaps3DispMap.php
@@ -42,7 +42,7 @@
4343 addOnloadHook(
4444 function() {
4545 initGMap3(
46 - '$mapName',
 46+ "$mapName",
4747 {
4848 zoom: $this->zoom,
4949 lat: $this->centreLat,
Index: trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMapsDispPoint.php
@@ -40,7 +40,7 @@
4141 addOnloadHook(
4242 function() {
4343 initializeYahooMap(
44 - '$mapName',
 44+ "$mapName",
4545 $this->centreLat,
4646 $this->centreLon,
4747 $this->zoom,
Index: trunk/extensions/Maps/Services/YahooMaps/Maps_YahooMapsDispMap.php
@@ -35,7 +35,7 @@
3636 addOnloadHook(
3737 function() {
3838 initializeYahooMap(
39 - '$mapName',
 39+ "$mapName",
4040 $this->centreLat,
4141 $this->centreLon,
4242 $this->zoom,
Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispPoint.php
@@ -46,14 +46,14 @@
4747 addOnloadHook(
4848 function() {
4949 initOpenLayer(
50 - '$mapName',
 50+ "$mapName",
5151 $this->centreLon,
5252 $this->centreLat,
5353 $this->zoom,
5454 [$layerItems],
5555 [$this->controls],
5656 $this->markerJs,
57 - '$langCode'
 57+ "$langCode"
5858 );
5959 }
6060 );
Index: trunk/extensions/Maps/Services/OpenLayers/Maps_OpenLayersDispMap.php
@@ -41,14 +41,14 @@
4242 addOnloadHook(
4343 function() {
4444 initOpenLayer(
45 - '$mapName',
 45+ "$mapName",
4646 $this->centreLon,
4747 $this->centreLat,
4848 $this->zoom,
4949 [$layerItems],
5050 [$this->controls],
5151 [],
52 - '$langCode'
 52+ "$langCode"
5353 );
5454 }
5555 );
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMapsDispMap.php
@@ -57,7 +57,7 @@
5858 Html::inlineScript( <<<EOT
5959 addOnloadHook(
6060 function() {
61 - initializeGoogleMap('$mapName',
 61+ initializeGoogleMap("$mapName",
6262 {
6363 lat: $this->centreLat,
6464 lon: $this->centreLon,
Index: trunk/extensions/Maps/Services/GoogleMaps/Maps_GoogleMapsDispPoint.php
@@ -58,7 +58,7 @@
5959 <<<EOT
6060 addOnloadHook(
6161 function() {
62 - initializeGoogleMap('$mapName',
 62+ initializeGoogleMap("$mapName",
6363 {
6464 lat: $this->centreLat,
6565 lon: $this->centreLon,

Status & tagging log