r69580 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69579‎ | r69580 | r69581 >
Date:05:59, 20 July 2010
Author:overlordq
Status:ok (Comments)
Tags:
Comment:
Followup to r69542, since the new installer doesn't support PG, this is going into updaters.inc
Modified paths:
  • /trunk/phase3/maintenance/postgres/tables.sql (modified) (history)
  • /trunk/phase3/maintenance/updaters.inc (modified) (history)

Diff [purge]

Index: trunk/phase3/maintenance/postgres/tables.sql
——@@ -392,7 +392,9 @@
393393 iw_prefix TEXT NOT NULL UNIQUE,
394394 iw_url TEXT NOT NULL,
395395 iw_local SMALLINT NOT NULL,
396 - iw_trans SMALLINT NOT NULL DEFAULT 0
 396+ iw_trans SMALLINT NOT NULL DEFAULT 0,
 397+ iw_api TEXT NOT NULL,
 398+ iw_wikiid TEXT NOT NULL,
397399 );
398400
399401
Index: trunk/phase3/maintenance/updaters.inc
——@@ -1436,6 +1436,8 @@
14371437 array( "user_newtalk", "user_last_timestamp", "TIMESTAMPTZ" ),
14381438 array( "logging", "log_user_text", "TEXT NOT NULL DEFAULT ''" ),
14391439 array( "logging", "log_page", "INTEGER" ),
 1440+ array( "interwiki", "iw_api", "TEXT NOT NULL"),
 1441+ array( "interwiki", "iw_wikiid", "TEXT NOT NULL"),
14401442 );
14411443
14421444

Follow-up revisions

RevisionCommit summaryAuthorDate
r69581Followup to r69580, did I mention MySQL sucks?overlordq06:02, 20 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69542Add iw_api and iw_wikiid fields to the interwiki table, plus rudimentary supp...catrope11:55, 19 July 2010

Comments

#Comment by 😂 (talk | contribs)   12:30, 20 July 2010

Maybe one of the people "supporting" PG should take the time to work on its new installer support.

#Comment by OverlordQ (talk | contribs)   16:51, 20 July 2010

Yes, but new-installer isn't ready, updaters is. So I could either add it to updaters and the wiki would install and update fine, or spend however long it would take to even understand what the new installer does since it's seriously lacking in code comments.

#Comment by MaxSem (talk | contribs)   17:15, 20 July 2010

New installer is ready enough not to be reverted and be the installer of 1.17. You can start writing support for it right now.

#Comment by OverlordQ (talk | contribs)   17:17, 20 July 2010

Ready enough to not be reverted and ready enough to actually be functional are two different things.

#Comment by 😂 (talk | contribs)   13:47, 21 July 2010

If we don't finish it before 1.17 branches then it will be split back off into a branch.

#Comment by 😂 (talk | contribs)   13:46, 21 July 2010

PG needs to do what Brion did in r31598. Only putting it in the format that MysqlUpdater does now.

Status & tagging log