r69545 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69544‎ | r69545 | r69546 >
Date:13:15, 19 July 2010
Author:danny_b
Status:ok (Comments)
Tags:accessibility 
Comment:
* #siteSub (tagline) isn't headline -> replaced by div (partial fix to bug 457)
Modified paths:
  • /trunk/phase3/skins/MonoBook.php (modified) (history)
  • /trunk/phase3/skins/Vector.php (modified) (history)

Diff [purge]

Index: trunk/phase3/skins/Vector.php
——@@ -487,7 +487,7 @@
488488 <!-- bodyContent -->
489489 <div id="bodyContent">
490490 <!-- tagline -->
491 - <h3 id="siteSub"><?php $this->msg( 'tagline' ) ?></h3>
 491+ <div id="siteSub"><?php $this->msg( 'tagline' ) ?></div>
492492 <!-- /tagline -->
493493 <!-- subtitle -->
494494 <div id="contentSub"<?php $this->html('userlangattributes') ?>><?php $this->html( 'subtitle' ) ?></div>
Index: trunk/phase3/skins/MonoBook.php
——@@ -76,7 +76,7 @@
7777
7878 <h1 id="firstHeading" class="firstHeading"><?php $this->html('title') ?></h1>
7979 <div id="bodyContent">
80 - <h3 id="siteSub"><?php $this->msg('tagline') ?></h3>
 80+ <div id="siteSub"><?php $this->msg('tagline') ?></div>
8181 <div id="contentSub"<?php $this->html('userlangattributes') ?>><?php $this->html('subtitle') ?></div>
8282 <?php if($this->data['undelete']) { ?>
8383 <div id="contentSub2"><?php $this->html('undelete') ?></div>

Follow-up revisions

RevisionCommit summaryAuthorDate
r697351.16wmf4: MFT r69545catrope17:14, 22 July 2010

Comments

#Comment by Trevor Parscal (WMF) (talk | contribs)   23:58, 20 July 2010

This seems totally sane, and I'm going to approve this, but we need to watch out for overqualified CSS rules like h3#siteSub in MediaWiki:Vector.css and MediaWiki:Monobook.css on all of our sites now.

#Comment by Danny B. (talk | contribs)   22:03, 21 July 2010

MediaWiki:Commons.css should be checked as well.

#Comment by The Evil IP address (talk | contribs)   09:03, 22 July 2010

Whereas I think it's good to change this, now after changing it, the tagline is now extremely small when printing. Just compare http://translatewiki.net/w/i.php?title=FAQ&printable=yes with the new design with http://de.wikipedia.org/w/index.php?title=Hamburg&printable=yes the old design. I think one of the reasons to use a

there was to make a visual difference from the other page content, making it like some kind of subtitle when printing. This should be fixed with CSS.

#Comment by The Evil IP address (talk | contribs)   09:04, 22 July 2010

Oh, sorry, something went wrong there. I was just writing

and then it formatted it like that. Some way to fix it?

#Comment by Nikerabbit (talk | contribs)   10:50, 22 July 2010

Using preview before submitting? :)

#Comment by P858snake (talk | contribs)   13:04, 22 July 2010

<h3>test</h3>

#Comment by P858snake (talk | contribs)   13:04, 22 July 2010

Ment to show, Using nowiki tags to contain it >.<

#Comment by Catrope (talk | contribs)   13:05, 22 July 2010

Per this comment, this revision needs accompanying changes to the print CSS. Marking as fixme and not deploying to the live site just yet.

#Comment by Danny B. (talk | contribs)   15:39, 22 July 2010

You are comparing two different skins. TWN has modern skin by default. So your article would have the same smaller slogan in Modern.

Compare also to Cologne Blue or Nostalgia.

And in fact there is absolutely no reason to emphasize such line as "some kind of subtitle", since it is definitely not a subtitle at all. (Actually in real life, such attribution would rather be displayed in footer.)

Status & tagging log