r69531 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69530‎ | r69531 | r69532 >
Date:04:23, 19 July 2010
Author:jeroendedauw
Status:ok (Comments)
Tags:
Comment:
Removed redundant array_reverse I found 3 months back
Modified paths:
  • /trunk/phase3/includes/Preferences.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Preferences.php
@@ -232,7 +232,7 @@
233233
234234 // Language
235235 global $wgContLanguageCode;
236 - $languages = array_reverse( Language::getLanguageNames( false ) );
 236+ $languages = Language::getLanguageNames( false );
237237 if ( !array_key_exists( $wgContLanguageCode, $languages ) ) {
238238 $languages[$wgContLanguageCode] = $wgContLanguageCode;
239239 }

Comments

#Comment by Simetrical (talk | contribs)   00:06, 20 July 2010

ksort()ed a few lines below, so looks like this is correct.

Status & tagging log