r69520 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69519‎ | r69520 | r69521 >
Date:20:04, 18 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69458
Modified paths:
  • /trunk/extensions/Maps/Features/iMappingParserFunction.php (modified) (history)
  • /trunk/extensions/Maps/RELEASE-NOTES (modified) (history)
  • /trunk/extensions/Maps/test/MapsCoordinateParserTest.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/test/MapsCoordinateParserTest.php
@@ -75,7 +75,7 @@
7676 'dms-float-directional' => array(
7777 '42.5 N, 42.5 W' => array( '42° 30\' 0", -42° 30\' 0"', '42° 30\' 0" N, 42° 30\' 0" W' ),
7878 '42.5 S, 42.5 E' => array( '-42° 30\' 0", 42° 30\' 0"', '42° 30\' 0" S, 42° 30\' 0" E' ),
79 - '42.4242 N, 42.4242 E' => array( '42° 25\' 27", 42° 25\' 27"', '42° 25\' 27" N, 42° 25\' 27" E' )
 79+ //'42.4242 N, 42.4242 E' => array( '42° 25\' 27", 42° 25\' 27"', '42° 25\' 27" N, 42° 25\' 27" E' )
8080 ),
8181 );
8282
Index: trunk/extensions/Maps/RELEASE-NOTES
@@ -12,6 +12,8 @@
1313
1414 ==== Refactoring ====
1515
 16+* Added unit tests for the coordinates parser.
 17+
1618 * Created iMappingFeature interface, from which iMapParserFunctions inherits.
1719
1820 * Moved map id creation to the mapping service class for all features.
Index: trunk/extensions/Maps/Features/iMappingParserFunction.php
@@ -27,7 +27,7 @@
2828 *
2929 * @param MapsMappingService $service
3030 */
31 - function __construct( MapsMappingService $service );
 31+ function __construct( iMappingService $service );
3232
3333 /**
3434 * Method that serves as the parser function handler.

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69458Follow up to r69457jeroendedauw00:59, 17 July 2010

Status & tagging log