r69457 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69456‎ | r69457 | r69458 >
Date:00:54, 17 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Changes for 0.6.5 - refactoring
Modified paths:
  • /trunk/extensions/Maps/Services/Maps_MappingService.php (modified) (history)
  • /trunk/extensions/Maps/Services/iMappingService.php (modified) (history)

Diff [purge]

Index: trunk/extensions/Maps/Services/Maps_MappingService.php
@@ -92,14 +92,9 @@
9393 }
9494
9595 /**
96 - * Returns the service parameters by first checking if they have been initialized yet,
97 - * doing to work if this is not the case, and then returning them.
98 - *
99 - * @since 0.6.3
100 - *
10196 * @see iMappingService::getParameterInfo
10297 *
103 - * @return array
 98+ * @since 0.6.3
10499 */
105100 public final function getParameterInfo() {
106101 if ( $this->parameterInfo === false ) {
@@ -120,23 +115,18 @@
121116 }
122117
123118 /**
124 - * Adds a feature to this service. This is to indicate this service has support for this feature.
 119+ * @see iMappingService::addFeature
125120 *
126121 * @since 0.6.3
127 - *
128 - * @param string $featureName
129 - * @param string $handlingClass
130122 */
131123 public function addFeature( $featureName, $handlingClass ) {
132124 $this->features[$featureName] = $handlingClass;
133125 }
134126
135127 /**
136 - * Adds the mapping services dependencies to the header.
 128+ * @see iMappingService::addDependencies
137129 *
138130 * @since 0.6.3
139 - *
140 - * @param mixed $parserOrOut
141131 */
142132 public final function addDependencies( &$parserOrOut ) {
143133 $dependencies = $this->getDependencyHtml();
@@ -153,11 +143,9 @@
154144 }
155145
156146 /**
157 - * Returns the html for the needed dependencies or false.
 147+ * @see iMappingService::getDependencyHtml
158148 *
159149 * @since 0.6.3
160 - *
161 - * @return mixed String or false
162150 */
163151 public final function getDependencyHtml() {
164152 $allDependencies = array_merge( $this->getDependencies(), $this->dependencies );
Index: trunk/extensions/Maps/Services/iMappingService.php
@@ -59,6 +59,34 @@
6060 function addDependency( $dependencyHtml );
6161
6262 /**
 63+ * Adds a feature to this service. This is to indicate this service has support for this feature.
 64+ *
 65+ * @since 0.6.5
 66+ *
 67+ * @param string $featureName
 68+ * @param string $handlingClass
 69+ */
 70+ function addFeature( $featureName, $handlingClass );
 71+
 72+ /**
 73+ * Adds the mapping services dependencies to the header.
 74+ *
 75+ * @since 0.6.5
 76+ *
 77+ * @param mixed $parserOrOut
 78+ */
 79+ function addDependencies( &$parserOrOut );
 80+
 81+ /**
 82+ * Returns the html for the needed dependencies or false.
 83+ *
 84+ * @since 0.6.5
 85+ *
 86+ * @return mixed String or false
 87+ */
 88+ function getDependencyHtml();
 89+
 90+ /**
6391 * Returns the name of the class that handles the provided feature in this service, or false if there is none.
6492 *
6593 * @since 0.6.5

Follow-up revisions

RevisionCommit summaryAuthorDate
r69458Follow up to r69457jeroendedauw00:59, 17 July 2010

Status & tagging log