r69505 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69504‎ | r69505 | r69506 >
Date:13:16, 18 July 2010
Author:ialex
Status:ok
Tags:
Comment:
Removed error suppression operators (per bug 24159)
Modified paths:
  • /trunk/phase3/thumb.php (modified) (history)

Diff [purge]

Index: trunk/phase3/thumb.php
@@ -101,8 +101,8 @@
102102 // Calculate time
103103 wfSuppressWarnings();
104104 $imsUnix = strtotime( $imsString );
 105+ $stat = stat( $sourcePath );
105106 wfRestoreWarnings();
106 - $stat = @stat( $sourcePath );
107107 if ( $stat['mtime'] <= $imsUnix ) {
108108 header( 'HTTP/1.1 304 Not Modified' );
109109 return;
@@ -164,7 +164,7 @@
165165 header( 'HTTP/1.1 500 Internal server error' );
166166 }
167167 if( $wgShowHostnames ) {
168 - $url = htmlspecialchars( @$_SERVER['REQUEST_URI'] );
 168+ $url = htmlspecialchars( isset( $_SERVER['REQUEST_URI'] ) ? $_SERVER['REQUEST_URI'] : '' );
169169 $hostname = htmlspecialchars( wfHostname() );
170170 $debug = "<!-- $url -->\n<!-- $hostname -->\n";
171171 } else {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68900And one error suppression opertator less (per bug 24159)ialex19:10, 2 July 2010
r68971Two error suppression opertators less (per bug 24159)ialex20:35, 3 July 2010
r69016Removed error suppression opertators (per bug 24159)ialex20:43, 4 July 2010

Status & tagging log