r68971 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r68970‎ | r68971 | r68972 >
Date:20:35, 3 July 2010
Author:ialex
Status:ok
Tags:
Comment:
Two error suppression opertators less (per bug 24159)
Modified paths:
  • /trunk/phase3/includes/HTMLFileCache.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/HTMLFileCache.php
@@ -209,11 +209,21 @@
210210
211211 public static function clearFileCache( $title ) {
212212 global $wgUseFileCache;
213 - if( !$wgUseFileCache ) return false;
 213+
 214+ if ( !$wgUseFileCache ) {
 215+ return false;
 216+ }
 217+
 218+ wfSuppressWarnings();
 219+
214220 $fc = new self( $title, 'view' );
215 - @unlink( $fc->fileCacheName() );
 221+ unlink( $fc->fileCacheName() );
 222+
216223 $fc = new self( $title, 'raw' );
217 - @unlink( $fc->fileCacheName() );
 224+ unlink( $fc->fileCacheName() );
 225+
 226+ wfRestoreWarnings();
 227+
218228 return true;
219229 }
220230 }

Follow-up revisions

RevisionCommit summaryAuthorDate
r69016Removed error suppression opertators (per bug 24159)ialex20:43, 4 July 2010
r69505Removed error suppression operators (per bug 24159)ialex13:16, 18 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r68900And one error suppression opertator less (per bug 24159)ialex19:10, 2 July 2010

Status & tagging log