r69455 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69454‎ | r69455 | r69456 >
Date:00:24, 17 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69451
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php
@@ -48,13 +48,8 @@
4949 global $wgOut;
5050 global $smgScriptPath, $smgYahooFormsOnThisPage, $smgStyleVersion, $egMapsJsExt;
5151
 52+ $this->service->addDependency( Html::linkedScript( "$smgScriptPath/Services/YahooMaps/SM_YahooMapsFunctions{$egMapsJsExt}?$smgStyleVersion" ) );
5253 $this->service->addDependencies( $wgOut );
53 -
54 - if ( empty( $smgYahooFormsOnThisPage ) ) {
55 - $smgYahooFormsOnThisPage = 0;
56 -
57 - $wgOut->addScriptFile( "$smgScriptPath/Services/YahooMaps/SM_YahooMapsFunctions{$egMapsJsExt}?$smgStyleVersion" );
58 - }
5954 }
6055
6156 /**
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php
@@ -38,13 +38,8 @@
3939 global $wgOut;
4040 global $smgScriptPath, $smgOLFormsOnThisPage, $smgStyleVersion, $egMapsJsExt;
4141
 42+ $this->service->addDependency( Html::linkedScript( "$smgScriptPath/Services/OpenLayers/SM_OpenLayersFunctions{$egMapsJsExt}?$smgStyleVersion" ) );
4243 $this->service->addDependencies( $wgOut );
43 -
44 - if ( empty( $smgOLFormsOnThisPage ) ) {
45 - $smgOLFormsOnThisPage = 0;
46 -
47 - $wgOut->addScriptFile( "$smgScriptPath/Services/OpenLayers/SM_OpenLayersFunctions{$egMapsJsExt}?$smgStyleVersion" );
48 - }
4944 }
5045
5146 /**
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -52,12 +52,8 @@
5353 global $wgOut;
5454 global $smgScriptPath, $smgGoogleFormsOnThisPage, $smgStyleVersion, $egMapsJsExt;
5555
 56+ $this->service->addDependency( Html::linkedScript( "$smgScriptPath/Services/GoogleMaps/SM_GoogleMapsFunctions{$egMapsJsExt}?$smgStyleVersion" ) );
5657 $this->service->addDependencies( $wgOut );
57 -
58 - if ( empty( $smgGoogleFormsOnThisPage ) ) {
59 - $smgGoogleFormsOnThisPage = 0;
60 - $wgOut->addScriptFile( "$smgScriptPath/Services/GoogleMaps/SM_GoogleMapsFunctions{$egMapsJsExt}?$smgStyleVersion" );
61 - }
6258 }
6359
6460 /**
Index: trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php
@@ -192,6 +192,8 @@
193193
194194 $this->addSpecificMapHTML();
195195
 196+ $this->addFormDependencies();
 197+
196198 return array( $this->output . $this->errorList, '' );
197199 }
198200

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69451Changes for 0.6.5 - improvements to form input handlingjeroendedauw23:51, 16 July 2010

Status & tagging log