r69454 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69453‎ | r69454 | r69455 >
Date:00:14, 17 July 2010
Author:jeroendedauw
Status:deferred
Tags:
Comment:
Follow up to r69451
Modified paths:
  • /trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php (modified) (history)
  • /trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php (modified) (history)

Diff [purge]

Index: trunk/extensions/SemanticMaps/Services/YahooMaps/SM_YahooMapsFormInput.php
@@ -60,7 +60,7 @@
6161 /**
6262 * @see MapsMapFeature::addSpecificMapHTML
6363 */
64 - protected function addSpecificMapHTML() {
 64+ public function addSpecificMapHTML() {
6565 global $wgOut;
6666
6767 $mapName = $this->service->getMapId( false );
Index: trunk/extensions/SemanticMaps/Services/OpenLayers/SM_OpenLayersFormInput.php
@@ -50,7 +50,7 @@
5151 /**
5252 * @see MapsMapFeature::addSpecificMapHTML
5353 */
54 - protected function addSpecificMapHTML() {
 54+ public function addSpecificMapHTML() {
5555 global $wgOut, $wgLang;
5656
5757 $mapName = $this->service->getMapId( false );
Index: trunk/extensions/SemanticMaps/Services/GoogleMaps/SM_GoogleMapsFormInput.php
@@ -63,7 +63,7 @@
6464 /**
6565 * @see MapsMapFeature::addSpecificFormInputHTML
6666 */
67 - protected function addSpecificMapHTML() {
 67+ public function addSpecificMapHTML() {
6868 global $wgOut;
6969
7070 $mapName = $this->service->getMapId( false );
Index: trunk/extensions/SemanticMaps/Features/FormInputs/SM_FormInput.php
@@ -39,6 +39,8 @@
4040
4141 protected $specificParameters = false;
4242
 43+ protected $coordsFieldName;
 44+
4345 private $coordinates;
4446
4547 /**
@@ -99,7 +101,7 @@
100102 */
101103 $parameterInfo = array_merge_recursive( MapsMapper::getCommonParameters(), SMFormInputs::$parameters );
102104 $parameterInfo = array_merge_recursive( $parameterInfo, $this->service->getParameterInfo() );
103 - $parameterInfo = array_merge_recursive( $parameterInfo, $this->specificParameters );
 105+ $parameterInfo = array_merge_recursive( $parameterInfo, $this->getSpecificParameterInfo() );
104106
105107 $manager = new ValidatorManager();
106108
@@ -137,8 +139,6 @@
138140
139141 $this->coordinates = $coordinates;
140142
141 - $this->setMapSettings();
142 -
143143 $showInput = $this->setMapProperties( $field_args );
144144
145145 if ( !$showInput ) {
@@ -151,7 +151,7 @@
152152
153153 // Create html element names.
154154 $mapName = $this->service->getMapId();
155 - $coordsFieldName = $mapName . '_coords_' . $sfgTabIndex;
 155+ $this->coordsFieldName = $mapName . '_coords_' . $sfgTabIndex;
156156 $infoFieldName = $mapName . '_info_' . $sfgTabIndex;
157157
158158 $geocodingFunction = $this->getShowAddressFunction();
@@ -164,7 +164,7 @@
165165 array(
166166 'size' => 42, #_O
167167 'tabindex' => $sfgTabIndex,
168 - 'id' => $coordsFieldName
 168+ 'id' => $this->coordsFieldName
169169 )
170170 );
171171
@@ -236,7 +236,7 @@
237237 $notFoundText = Xml::escapeJsString( wfMsg( 'semanticmaps_notfound' ) );
238238 $mapName = Xml::escapeJsString( $mapName );
239239 $geoFieldName = Xml::escapeJsString( $geocodeFieldName );
240 - $coordFieldName = Xml::escapeJsString( $geocodeFieldName );
 240+ $coordFieldName = Xml::escapeJsString( $this->coordsFieldName );
241241
242242 $this->output .= '<p>' . $adressField .
243243 Html::input(

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69451Changes for 0.6.5 - improvements to form input handlingjeroendedauw23:51, 16 July 2010

Status & tagging log