r69316 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69315‎ | r69316 | r69317 >
Date:22:30, 13 July 2010
Author:platonides
Status:deferred
Tags:
Comment:
* $parser->disableCache(); can't be called from ParserFirstCallInit (Call to a member function setCacheTime() on a non-object)
* "Parameter 3 to efDonateRender() expected to be a reference, value given"
* Use $wgExtensionAssetsPath
Modified paths:
  • /trunk/extensions/DonationInterface/donate_interface/donate_interface.php (modified) (history)

Diff [purge]

Index: trunk/extensions/DonationInterface/donate_interface/donate_interface.php
@@ -37,8 +37,6 @@
3838 //load extension messages
3939 wfLoadExtensionMessages( 'DonateInterface' );
4040
41 - $parser->disableCache();
42 -
4341 $parser->setHook( 'donate', 'efDonateRender' );
4442
4543 //process form
@@ -55,8 +53,8 @@
5654 * Outputs the donation landing page form which collects
5755 * the donation amount, currency and payment processor type.
5856 */
59 -function efDonateRender( $input, $args, &$parser ) {
60 - global $wgOut, $wgScriptPath;
 57+function efDonateRender( $input, $args, $parser ) {
 58+ global $wgOut, $wgExtensionAssetsPath;
6159
6260 $parser->disableCache();
6361
@@ -65,7 +63,7 @@
6664 //$chapter = fnDonateChapterRedirect();
6765
6866 // add JavaScript validation to <head>
69 - $wgOut->addScriptFile( $wgScriptPath . '/extensions/DonationInterface/donate_interface/donate_interface_validate_donation.js' );
 67+ $wgOut->addScriptFile( $wgExtensionAssetsPath . '/DonationInterface/donate_interface/donate_interface_validate_donation.js' );
7068
7169 //display form to gather data from user
7270 $output = fnDonateCreateOutput();

Status & tagging log