r69315 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69314‎ | r69315 | r69316 >
Date:22:16, 13 July 2010
Author:neilk
Status:ok
Tags:
Comment:
Modified paths:
  • /trunk/extensions/UploadWizard/TODO (deleted) (history)

Diff [purge]

Index: trunk/extensions/UploadWizard/TODO
@@ -1,49 +0,0 @@
2 -You can't use browser back button
3 - Yes, this will be a bit of a challenge. So far it's a NTH not a must have.
4 -
5 -Alert box "Please press this button to start your uploads." after pressing a button
6 - That's a mistake in the string
7 -
8 -<thedj> if i'm on the first page, there are two buttons. "add another file" "upload" and "next". I'm slightly confused about what I should do. Press next, or press upload.
9 - We used to have it so that upload and next were the same button, that is, once it was finished, it went immediately to the next page.
10 - That felt weird. But perhaps we should hide [next] until all files are uploaded.
11 -
12 -It exposes the local filename http://commons.prototype.wikimedia.org/wiki/File:Jimmy_Wales_being_a_good_citizen.png
13 - I don't understand the criticism. The local filename is likely to be useful; if not we will filter for common patterns
14 - of crappy autogenerated filenames.
15 -
16 -Upload with "null" as summary http://commons.prototype.wikimedia.org/w/index.php?title=File:Upload_wizard_deadlock.png&action=edit
17 - Fixing this
18 -
19 -Useless? "ZOMG THIS DEED IS NOT READY" message
20 - This is obviously a placeholder
21 -
22 -You can reach to a deadlock situation http://commons.prototype.wikimedia.org/wiki/File:Upload_wizard_deadlock.png
23 -
24 -Wizard tabs show a link pointer but you can't browse there.
25 -
26 -You are allowed to write new lines in the title (but should not)
27 -Also, it doesn't trim leading/trailing whitespace
28 -
29 -Font size in text fields is too small
30 -
31 -Add support for upload from url
32 -
33 -You can change the upload fields *after* they have been uploaded
34 -
35 -No option to add another file after the upload (merge upload with next button?)
36 - Agreed
37 -
38 -"To link to it in HTML, copy this HTML code:" fails for long urls (only the first line is shown,
39 -breaks at http://commons.prototype.wikimedia.org)
40 - Yup, agree here
41 -
42 -UploadWizardPage.js contains wiki config. It should be a <script> tag int the page.
43 - I don't understand this comment -- NeilK
44 -
45 -Noscript fallback doesn't work (no error either)
46 -
47 -Noscript fallback should be a html equivalent Wizard
48 - Highly unlikely. noscript fallback will be a simple HTML4 file uploader.
49 -
50 -

Status & tagging log