r69228 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:< r69227‎ | r69228 | r69229 >
Date:09:26, 10 July 2010
Author:demon
Status:ok (Comments)
Tags:
Comment:
Cleanup r69128, getStatArray() -> getStatusArray(). It's two characters, c'mon
Modified paths:
  • /trunk/phase3/includes/Status.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/Status.php
——@@ -254,7 +254,7 @@
255255 * @return Array
256256 */
257257 function getErrorsArray() {
258 - return $this->getStatArray( "error" );
 258+ return $this->getStatusArray( "error" );
259259 }
260260
261261 /**
——@@ -263,7 +263,7 @@
264264 * @return Array
265265 */
266266 function getWarningsArray() {
267 - return $this->getStatArray( "warning" );
 267+ return $this->getStatusArray( "warning" );
268268 }
269269
270270 /**
——@@ -272,7 +272,7 @@
273273 *
274274 * @return Array
275275 */
276 - protected function getStatArray( $type ) {
 276+ protected function getStatusArray( $type ) {
277277 $result = array();
278278 foreach ( $this->errors as $error ) {
279279 if ( $error['type'] === $type ) {

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69128* Add Status::getWarningsArray() to complement Status::getErrorsArray()...mah02:53, 7 July 2010

Comments

#Comment by MarkAHershberger (talk | contribs)   11:39, 10 July 2010

I had this fix as part of a bigger change, but couldn't figure out how to finish it up and lack of sleep is hurting my thinking. :( Shoulda just committed this.

#Comment by 😂 (talk | contribs)   11:48, 10 July 2010
)

Status & tagging log