r69204 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69203‎ | r69204 | r69205 >
Date:12:43, 9 July 2010
Author:demon
Status:ok
Tags:
Comment:
Cleanup to r69191: use addParserOutput() instead of addHtml(), specify current rev on Article, use doViewParse() so we can cache the ParserOutput
Modified paths:
  • /trunk/phase3/includes/diff/DifferenceInterface.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/diff/DifferenceInterface.php
@@ -444,11 +444,12 @@
445445 $wgOut->addHTML( "\n</pre>\n" );
446446 }
447447 } elseif( $pCache ) {
448 - $pOutput = ParserCache::singleton()->get( new Article( $this->mTitle ), $wgUser );
 448+ $article = new Article( $this->mTitle, 0 );
 449+ $pOutput = ParserCache::singleton()->get( $article, $wgUser );
449450 if( $pOutput ) {
450 - $wgOut->addHtml( $pOutput->getText() );
 451+ $wgOut->addParserOutput( $pOutput );
451452 } else {
452 - $wgOut->addWikiTextTidy( $this->mNewtext );
 453+ $article->doViewParse();
453454 }
454455 } else {
455456 $wgOut->addWikiTextTidy( $this->mNewtext );

Follow-up revisions

RevisionCommit summaryAuthorDate
r69414MFT r69191, r69204: use parser cache to display article HTML when diffing to ...tstarling01:44, 16 July 2010

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69191(bug 24124) Diffs are taking 10 to 20 seconds to load. Use parser cache for p...demon17:01, 8 July 2010

Status & tagging log