r69129 MediaWiki - Code Review archive

Repository:MediaWiki
Revision:r69128‎ | r69129 | r69130 >
Date:02:53, 7 July 2010
Author:mah
Status:resolved (Comments)
Tags:
Comment:
finish revert of r69108
Modified paths:
  • /trunk/phase3/includes/installer/WebInstaller.php (modified) (history)

Diff [purge]

Index: trunk/phase3/includes/installer/WebInstaller.php
@@ -81,10 +81,6 @@
8282 if ( isset( $session['settings'] ) ) {
8383 $this->settings = $session['settings'] + $this->settings;
8484 }
85 -
86 - /* Must be called after the session setup above */
87 - $this->setupDatabaseObjects();
88 -
8985 $this->exportVars();
9086 $this->setupLanguage();
9187

Past revisions this follows-up on

RevisionCommit summaryAuthorDate
r69108new-installer: Delay database object construction until ->execute time...avar20:40, 6 July 2010

Comments

#Comment by Ævar Arnfjörð Bjarmason (talk | contribs)   11:02, 7 July 2010

This is broken, see my comment in r69128.

Status & tagging log